Ticket #1176 (closed defect: fixed)
[PATCH] Fix Atlas starting canvas resolution on OS X
| Reported by: | historic_bruno | Owned by: | mk12 |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 10 |
| Component: | Atlas editor | Keywords: | atlas,sdl,wxwidgets,patch |
| Cc: | mk12360@… |
Description
Looks like the Atlas canvas init problem is back on OS X, the resolution is stuck on the default 320x240 instead of being updated to the full window size. I remember fixing this at some point but it's broken again. If you resize the window, the resolution gets updated properly, so it's just a matter of getting the initialization correct, I remember there's a specific init order that needs to be followed with our combination of SDL and wxWidgets.
Attachments
Change History
Changed 13 months ago by mk12
- Attachment AtlasUI-Canvas-size-Mac-quickfix.patch added
comment:1 Changed 13 months ago by mk12
- Cc mk12360@… added
- Keywords atlas,sdl,wxwidgets,patch,review added; atlas,sdl,wxwidgets removed
I don't know how to fix it properly but my patch should be reviewed so at least the hack is applied on OS X as well. Someone may want to spent the time to figure out how to do it in a nicer way.
comment:2 Changed 13 months ago by mk12
- Owner set to mk12
- Status changed from new to assigned
- Summary changed from Fix Atlas starting canvas resolution on OS X to [PATCH] Fix Atlas starting canvas resolution on OS X
- Milestone changed from Backlog to Alpha 10
comment:3 Changed 13 months ago by ben
- Status changed from assigned to closed
- Resolution set to fixed
In 11525:
comment:4 Changed 13 months ago by historic_bruno
- Keywords atlas,sdl,wxwidgets,patch added; atlas,sdl,wxwidgets,patch,review removed
I went ahead and used a slightly different solution which seems to work on Windows, Linux, and OS X, and avoids the current hack of adjusting the window size by 1 pixel.
includes os x in the window-resizing hack, and reverts the resize to make it 2% less hack-ish.