Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1176 closed defect (fixed)

[PATCH] Fix Atlas starting canvas resolution on OS X

Reported by: historic_bruno Owned by: Mitchell K
Priority: Should Have Milestone: Alpha 10
Component: Atlas editor Keywords: atlas, sdl, wxwidgets, patch
Cc: mk12360@… Patch:

Description

Looks like the Atlas canvas init problem is back on OS X, the resolution is stuck on the default 320x240 instead of being updated to the full window size. I remember fixing this at some point but it's broken again. If you resize the window, the resolution gets updated properly, so it's just a matter of getting the initialization correct, I remember there's a specific init order that needs to be followed with our combination of SDL and wxWidgets.

Attachments (2)

AtlasUI-Canvas-size-Mac-quickfix.patch (763 bytes ) - added by Mitchell K 12 years ago.
includes os x in the window-resizing hack, and reverts the resize to make it 2% less hack-ish.
AtlasUI-Canvas-size-Mac-quickfix(1176)-v2.patch (764 bytes ) - added by Mitchell K 12 years ago.

Download all attachments as: .zip

Change History (6)

by Mitchell K, 12 years ago

includes os x in the window-resizing hack, and reverts the resize to make it 2% less hack-ish.

comment:1 by Mitchell K, 12 years ago

Cc: mk12360@… added
Keywords: patch review added

I don't know how to fix it properly but my patch should be reviewed so at least the hack is applied on OS X as well. Someone may want to spent the time to figure out how to do it in a nicer way.

Last edited 12 years ago by Mitchell K (previous) (diff)

comment:2 by Mitchell K, 12 years ago

Milestone: BacklogAlpha 10
Owner: set to Mitchell K
Status: newassigned
Summary: Fix Atlas starting canvas resolution on OS X[PATCH] Fix Atlas starting canvas resolution on OS X

comment:3 by ben, 12 years ago

Resolution: fixed
Status: assignedclosed

In 11525:

Fixes Atlas canvas resolution init on OS X. Replaces hacky solution for the same problem on wxGTK. Fixes #1176.

comment:4 by historic_bruno, 12 years ago

Keywords: review removed

I went ahead and used a slightly different solution which seems to work on Windows, Linux, and OS X, and avoids the current hack of adjusting the window size by 1 pixel.

Note: See TracTickets for help on using tickets.