Ticket #128 (closed task: fixed)

Opened 7 years ago

Last modified 13 months ago

Minor fixes/improvements related to GUI

Reported by: jan Owned by: sluzky
Priority: If Time Permits Milestone: Pre-Alpha 1
Component: Core engine Keywords: gui
Cc: gustav, gee

Description (last modified by sluzky) (diff)

  • We now get warnings whenever there is a C++ file that is empty or doesn't contain any meaningful info (e.g. stuff that would end up in the compiled static library). Accordingly: decide if CGUIScrollBarStyle.cpp and CGUIList.cpp can be removed.
  • Some parts of the GUI still use the old and obsolete PS_ERROR mechanism. Removing that would be nice, to avoid confusion. Also, localization would be helped a bit by not having error text hard-coded in English.

If a return-value-based approach is still desired (instead of tossing exceptions), we could simply assign numbers to the error definitions, rename them a bit, and be done. Otherwise, we can move that over to Philip's error mechanism, i.e. throwing exceptions. I can help out and/or do all the work - just let me know which is preferable. (old TODO entry: move GUIbase.h errors (DECLARE_ERROR) into e.g. Philip's error mechanism, remove DECLARE_ERROR, remove ps/errors.h.)

Change History

comment:1 Changed 4 years ago by sluzky

  • Owner set to sluzky
  • Status changed from new to assigned

comment:2 Changed 4 years ago by sluzky

  • Description modified (diff)

deleted the remaining CGUIList.cpp

comment:3 Changed 4 years ago by sluzky

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [7147]) refactoring all PS_RESULT in GUI to PSRETURN/PSERROR closes #128

comment:4 Changed 4 years ago by sluzky

  • Description modified (diff)

gonna buff up the log for a while until all GUI settings are fixed

comment:5 Changed 3 years ago by anonymous

  • Milestone ASAP deleted

Milestone ASAP deleted

comment:6 Changed 13 months ago by historic_bruno

  • Milestone set to Pre-Alpha 1
Note: See TracTickets for help on using tickets.