Ticket #1333 (closed enhancement: fixed)

Opened 14 months ago

Last modified 12 months ago

[PATCH] Add map name and size to game summary screen

Reported by: rdxi Owned by: leper
Priority: Nice to Have Milestone: Alpha 11
Component: UI & Simulation Keywords: simple gui
Cc:

Description


Attachments

summary_map_name.patch (2.3 KB) - added by hapsky 13 months ago.
A first attempt at implementing this. The map size is displayed as a number.
summary_map_name_v2.patch (3.2 KB) - added by hapsky 13 months ago.
Updated patch to display the map size as a string.

Change History

comment:1 Changed 14 months ago by historic_bruno

  • Keywords simple gui added

comment:2 Changed 13 months ago by hapsky

Hello,

I've written a small patch to implement this. I've also taken the liberty of slightly adjusting the GUI layout of the summary screen ( just the top panel ). I'm also not aware of how to interpret the map size. The result I get from

Engine.GetMapSettings().Size

is an integer, but I suppose that has to be interpreted as a string ( Tiny, Normal, etc. ). If anyone has any ideas, I'm looking forward to them.

Changed 13 months ago by hapsky

A first attempt at implementing this. The map size is displayed as a number.

Changed 13 months ago by hapsky

Updated patch to display the map size as a string.

comment:3 Changed 13 months ago by hapsky

Ok, I've managed to display the size of the map a string, taken from "data/mods/public/simulation/data/map_sizes.json". If the map is a scenarion, the string "Scenario" is used instead of the map size.

Last edited 12 months ago by hapsky (previous) (diff)

comment:4 Changed 13 months ago by hapsky

  • Keywords review added
  • Summary changed from Add map name and size to game summary screen to [PATCH] Add map name and size to game summary screen
  • Milestone changed from Backlog to Alpha 11

comment:5 Changed 12 months ago by leper

  • Owner set to leper
  • Status changed from new to closed
  • Resolution set to fixed

In 12020:

Display map name and size on summary screen. Based on patch by hapsky. Fixes #1333.
Play victory and defeat music.
Replace celts with gauls.

comment:6 Changed 12 months ago by leper

  • Keywords review removed

Thanks for your patch.

Note: See TracTickets for help on using tickets.