#1487 closed defect (fixed)
[PATCH] Prevent land fauna from attacking ships
Reported by: | Peter | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 22 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Priqvel@…, knight.erraunt@… | Patch: |
Description
When ship attack lion, lion reply and attack ship, but he gets "into" the ship, to the core for attack, It causes of graphic issue. Lion just get absorbed by ship. And the second, I wish you could highlight cursos.And made spears a lil bit bigger, cuz sometimes hard to see it when grass on a background
Attachments (8)
Change History (32)
comment:1 by , 12 years ago
Component: | Core engine → UI & Simulation |
---|---|
Keywords: | lion ship cursor removed |
Priority: | Should Have → Nice to Have |
comment:2 by , 12 years ago
comment:3 by , 12 years ago
Summary: | Graphic issues. Lion attack ship → Prevent land fauna from attacking ships |
---|
by , 8 years ago
Attachment: | templates_land_fauna_ships_cant_touch.diff added |
---|
comment:4 by , 8 years ago
comment:5 by , 8 years ago
The patch mentioned above solves nothing. (will change it as soon as I have a proper one)
by , 8 years ago
Attachment: | some_stupid_solution.diff added |
---|
comment:6 by , 8 years ago
Ok, so I came up with this simple if which prevent's non SeaCreature(s) from attacking Ship(s). This solves the problem from this ticket. Anyways I believe it is extremely ugly, if anyone comes up with a neater idea, express it here and I will be more then glad to execute it (if one wants so of course).
comment:7 by , 8 years ago
Cc: | added |
---|---|
Keywords: | rfc patch added |
comment:8 by , 8 years ago
Summary: | Prevent land fauna from attacking ships → [PATCH] Prevent land fauna from attacking ships |
---|
comment:9 by , 8 years ago
Milestone: | Backlog → Alpha 21 |
---|
by , 8 years ago
Attachment: | bit_better_solution.diff added |
---|
comment:10 by , 8 years ago
After consulting this with Imarok on the IRC, I prepared an alternative solution - added Ship to the restricted classes of all the animal templates, it has some downside - if someone creates a SeaCreature based on one of these templates, it will not be able to attack Ships (Shark is created like that but it is not able to attack anyways so it is not a problem), or if someone does not used this templates he may create a land animal able to attack a Ship. To me both solutions are not that nice but at the same time both resolve the problem.
by , 8 years ago
Attachment: | restrictedclassesanimal.diff added |
---|
based on erraunt patch, removes useless identity entry, adress defensive animal case
comment:11 by , 8 years ago
Keywords: | review added; rfc removed |
---|
by , 8 years ago
Attachment: | restrictedclassesanimal.2.diff added |
---|
merge some elephant templates in the same move
comment:12 by , 8 years ago
- It was always fun when gaia elephants destroyed towers, civic centers or ships, because some arrow missed the target and hit the elephant :D
If there is a graphical issue with gaia elephants attacking ships, then there is likely one with war elephants too and many other units?
Does this also occur when just walking to the target instead of attack-moving there?
Why do structures become restricted?
- IMO it were nice to use relative for Health, Loot, ResourceSupply and where else possible
comment:13 by , 8 years ago
- Yes, perhaps elephants should still attack structure.
- The situation is different imo for players units and for animals (gaia animals will be stuck at the coast trying to attack the ship)
- Indeed (just use addition as there'll be issue with mul and integers for loot and resourcesupply)
comment:14 by , 8 years ago
Milestone: | Alpha 21 → Alpha 22 |
---|
Feel free to correct the milestone with a commit if it's well tested and addresses the comments. Relative templates probably not that crucial.
by , 7 years ago
Attachment: | only_elephants_can_attack_siege.patch added |
---|
comment:16 by , 7 years ago
Keywords: | rfc added |
---|
The empty identity components were removed already. fb's patch still seems ready to go mostly, so putting this under rfc. Would be nice if he or me finds the time to put it to phabricator or commit it. Also with regards to the attack cursor issue, females shouldn't be able to attack ships.
by , 7 years ago
by , 7 years ago
Attachment: | height.jpg added |
---|
comment:18 by , 7 years ago
From left to right, current stats:
African Bush (800 food, 300 HP, 75 XP, biggest footprint) Asian (650 food, 250 HP, 60 XP) North African (500 food, 200 HP, 50 XP, smallest footprint)
Loot was added for all eles in r10473
comment:19 by , 7 years ago
comment:21 by , 7 years ago
Keywords: | rfc removed |
---|
- Agreeing to keep the Loot values (removing Loot of the African Bush elephant must have been oversight).
- Agreeing to add
template_unit_fauna_hunt_defensive_elephant.xml
to the root tempalte directory, as that contains all inherited ones. - Agreeing that changing hp, xp and resource supply stats to additive relative numbers doesn't help, because if someone changes the parent template significantly, the relative numbers in the child templates become wrong too
- Agreeing that the infant template shouldn't inherit the new parent template, because it only shares Sound
- Agreeing that Structure should become restricted, because it is unexpected that gaia elephants destroy garrisoned civic centers that incidentally attacked a near elephant when the arrows intended to hit attacking enemies instead. This is commonly perceived as a bug, so it's better to remove that ability from the Gaia elephants.
- The empty Identity components had been nuked already, so that, besides the Loot part, is the only thing that was rebased / changed from your patch.
- The non-elephant changes should become a separate diff.
Thanks for the great cleanup patch!
comment:23 by , 7 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Hmm sounds like multiple problems. We should prevent ships from attacking land units and vice versa. And most gaia animals should stay away from water, especially deeper water, I think that could be done with passability classes.