Ticket #1544 (closed enhancement: fixed)

Opened 10 months ago

Last modified 10 months ago

[PATCH] Selection order is not preserved when renaming entities

Reported by: Deiz Owned by: Deiz
Priority: Should Have Milestone: Alpha 11
Component: UI & Simulation Keywords: patch
Cc:

Description

As the GUI's selection state depends on SpiderMonkey?'s ordering of keys in objects (insertion order), detecting renamed entities, removing the old and adding the new will shift entities from their old position to the end of the selection.

The only way to preserve the order is by rebuilding the selection and groups as necessary, which is luckily quite simple.

Attachments

selection-renamed.patch (2.5 KB) - added by Deiz 10 months ago.

Change History

Changed 10 months ago by Deiz

comment:1 Changed 10 months ago by quantumstate

  • Status changed from new to closed
  • Resolution set to fixed

In 12192:

Preserve selection order when entities are 'renamed'. Patch by Deiz/F00. Fixes #1544.
e.g. If you have a long wall as primary selection and CC as secondary, after the gate upgrade the wall (now gate) remains the primary selection.

comment:2 Changed 10 months ago by quantumstate

  • Keywords review removed

Some pretty minor polish, nice to have though :).

Note: See TracTickets for help on using tickets.