Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1664 closed defect (fixed)

non-pch build broken in A11

Reported by: Julian Ospald Owned by: leper
Priority: Must Have Milestone: Alpha 12
Component: Core engine Keywords:
Cc: stwf Patch:

Description (last modified by leper) 

../../../source/soundmanager/js/SoundPlayer.cpp: In member function ‘CStr8 JSoundPlayer::ToString(JSContext*, uintN, jsval*)’:
../../../source/soundmanager/js/SoundPlayer.cpp:76:21: error: aggregate ‘std::ostringstream stringStream’ has incomplete type and cannot be defined
../../../source/soundmanager/js/SoundPlayer.cpp:80:1: warning: control reaches end of non-void function

See ​http://irclogs.wildfiregames.com/2012-09-08-QuakeNet-%230ad-dev.log at 17:00 for another report.

MusicSound.cpp and SoundPlayer.cpp seem to be missing an include line.

Attachments (1)

20120909-123823.log​ (304.3 KB ) - added by Julian Ospald 12 years ago.

Download all attachments as: .zip

Change History (7)

by Julian Ospald, 12 years ago

Attachment: 20120909-123823.log​ added

comment:1 by Julian Ospald, 12 years ago

works nicely with pch enabled though...

comment:2 by leper, 12 years ago

Description: modified (diff)

comment:3 by Julian Ospald, 12 years ago

<leper> hasufell: I suppose the easy solution to that would be to add '#include <sstream>' to both files but I don't understand the use of ostringstream instead of CStr...

that worked. Please fiex.

comment:4 by leper, 12 years ago

Owner: set to leper
Resolution: → fixed
Status: new → closed

In 12655:

Fix non-pch build. Fixes #1664.

comment:5 by leper, 12 years ago

Cc: stwf added
Milestone: Backlog → Alpha 12

I'm adding stwf to cc even though this bug is fixed as I don't really understand the use of ostringstream instead of CStr (as we're returning one in both cases).

comment:6 by Julian Ospald, 12 years ago

thanks

Note: See TracTickets for help on using tickets.