Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1759 closed defect (fixed)

[PATCH] Units sometimes are rendered as carrying resources while they are not

Reported by: zoot Owned by: zoot
Priority: Should Have Milestone: Alpha 13
Component: Core engine Keywords: patch
Cc: Patch:

Description (last modified by zoot)

Steps to reproduce:

  1. Gather some resources with a unit.
  2. While the unit is still carrying the resouces, garrison the unit.
  3. Ungarrison the unit.

What happens:

The resources are dropped from the unit, but when it walks, it still shows as carrying the resources.

http://trac.wildfiregames.com/raw-attachment/ticket/1759/screenshot0027.png

I've attached the relevant commands.txt in case it is of any use. The commands.txt is dated "dec 11 22:59" and the screenshot above is dated "dec 12 00:17", so it happens around 1:15 hours into the game.

This was on this revision: ​https://github.com/0ad/0ad/commit/f603bf9b0cd03ff2128d3f5850c76c8d7ab28f8f

Attachments (2)

screenshot0027.png​ (305.4 KB ) - added by zoot 11 years ago.
commands.txt.gz​ (90.7 KB ) - added by zoot 11 years ago.

Download all attachments as: .zip

Change History (13)

by zoot, 11 years ago

Attachment: screenshot0027.png​ added

comment:1 by zoot, 11 years ago

Description: modified (diff)

by zoot, 11 years ago

Attachment: commands.txt.gz​ added

comment:2 by zoot, 11 years ago

Description: modified (diff)

comment:3 by zoot, 11 years ago

Description: modified (diff)

comment:4 by Kieran P, 11 years ago

Which revision were you using?

comment:5 by zoot, 11 years ago

Description: modified (diff)

This was on this revision: ​​https://github.com/0ad/0ad/commit/f603bf9b0cd03ff2128d3f5850c76c8d7ab28f8f

Last edited 11 years ago by zoot (previous) (diff)

comment:6 by zoot, 11 years ago

Steps to reproduce:

  1. Gather some resources with a unit.
  2. While the unit is still carrying the resouces, garrison the unit.
  3. Ungarrison the unit.

What happens:

The resources are dropped from the unit, but when it walks, it still shows as carrying the resources.

Last edited 11 years ago by zoot (previous) (diff)

comment:7 by zoot, 11 years ago

Description: modified (diff)

comment:8 by zoot, 11 years ago

Description: modified (diff)

comment:9 by zoot, 11 years ago

Keywords: patch review added
Milestone: Backlog → Alpha 13
Owner: set to zoot
Status: new → assigned
Summary: Units sometimes are rendered as carrying resources while they are not → [PATCH] Units sometimes are rendered as carrying resources while they are not

Fix for this issue here:

​https://github.com/zootzoot/0ad/compare/1759

The diff is here:

​https://github.com/zootzoot/0ad/compare/1759.diff

comment:10 by leper, 11 years ago

Resolution: → fixed
Status: assigned → closed

In 13073:

Don't use the carrying animation when a unit is ungarrisoned and it dropped of the resources while garrisoning. Patch by zoot. Fixes #1759.

comment:11 by leper, 11 years ago

Keywords: review removed

Thanks for the patch.

Note: See TracTickets for help on using tickets.