Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1838 closed defect (fixed)

User mods don't work correctly with public.zip

Reported by: historic_bruno Owned by: leper
Priority: Nice to Have Milestone: Alpha 13
Component: Core engine Keywords: archive cache vfs
Cc: Patch:

Description

Easy to reproduce:

  • install the game from a package that uses public.zip (I used the Windows installer)
  • create a new mod folder like 'mymod'
  • add a GUI file in 'mymod', e.g. change some text in gui/pregame/mainmenu.xml
  • run the game with -mod=mymod
  • notice the GUI change isn't picked up

But you can extract the contents of public.zip inside public and rename or delete the zip, then the GUI mod is used as expected.

Change History (5)

comment:1 by leper, 11 years ago

I have a fix for this in my work on the config system.

comment:2 by Kieran P, 11 years ago

Milestone: Backlog → Alpha 13
Owner: set to leper
Priority: Should Have → Nice to Have

comment:3 by leper, 11 years ago

Resolution: → fixed
Status: new → closed

In 13167:

Fix mod priority. Add user mod support. Fixes #1838.

in reply to:  3 comment:4 by historic_bruno, 11 years ago

Replying to leper:

In 13167:

Fix mod priority. Add user mod support. Fixes #1838.

This commit introduces some build warnings on MSVC: 

2>..\..\..\source\ps\GameSetup\GameSetup.cpp(477): warning C4245: 'argument' : conversion from 'int' to 'size_t', signed/unsigned mismatch
2>..\..\..\source\ps\GameSetup\GameSetup.cpp(479): warning C4245: 'argument' : conversion from 'int' to 'size_t', signed/unsigned mismatch

comment:5 by leper, 11 years ago

In 13180:

Fix MSVC warning. Refs #1838.
Remove special support for removed internal mod.

Note: See TracTickets for help on using tickets.