[PATCH] Profiler got corrupted: showing all as unlogged

[Markus]

Sometimes the profiles shows bogus values. Everything is zero just the unlogged takes the whole time.

The problem happens when the hierachical profiler is not stopped where its started for. The C++ implementation is safe due to an objects destructor. But the start/stop functions are also exported to JS where the stop seems to be forgotten. So all following profiles are put under this single node in the tree, never stopping the parent and hiding them from the gui.

[Yves]

I think the overall approach isn't bad and I can't think of a better one. I haven't done a "full" review, but here's just one thing I noticed. You changed the normal profiling (CProfileSample) to silently ignore when non-main threads try to use the profiler instead of causing an assertion. Programmers who try using Profiler1 in non-main threads won't notice it if they aren't careful enough. This will only cause unused code and nothing worse, though. If I understand it correctly, that's the whole purpose of the separate CProfileSample and CProfileSampleScript classes. If this little difference isn't important we could as well just scrap one of the classes and avoid duplicated code.

[Markus]

Regarding "Aegis bot": #1945

[Markus]

The output is filtered and normally not displayed. As its an error, removed the filtering.

[historic_bruno]

I haven't tested the patch, but one thing that needs to be corrected is the printf formatting should use either %hs or %ls for printing C strings.

[historic_bruno]

The patch seems to detect incorrect profiling calls, as a test I removed a ProfileStart from Petra AI. However, the profiler consistently crashes after that:

PROFILER: Current not right: Should be "AI script" but is "sim update"
PROFILER: Skip "sim update". This profiler was not stopped correctly!
PROFILER: Did not find the right callee in the stack but reached root: Performing reset.
First-chance exception at 0x001c954c in pyrogenesis.exe: 0xC0000005: Access violation reading location 0x00000000.
Unhandled exception at 0x001c954c in pyrogenesis.exe: 0xC0000005: Access violation reading location 0x00000000.

The same crash occurs without the patch, so it's difficult to tell how the patch helps.