#2055 closed enhancement (fixed)
[PATCH] Implement: Allies share vision an unlocking technology
Reported by: | michael | Owned by: | Niek |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 19 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description
I would like to make Allied shared vision an unlocking technology ("Cartography" or something along these lines).
Basically, allies start the match without shared vision, but then unlock shared vision after researching a technology. This is a standard thing in Age of Empires games.
Attachments (7)
Change History (22)
follow-up: 2 comment:1 by , 11 years ago
Component: | Core engine → UI & Simulation |
---|---|
Keywords: | simple added; Line of Sight Vision Allies Technologies removed |
comment:2 by , 11 years ago
Replying to leper:
Do both players have to research this for it to work (I think so but it's been some time since I last played AoE)
Not in AoK, as soon as you build a market and research cartography, you get LOS of your allies. I'm not sure if I like this more as a technology, or something you get automatically at a certain phase, or as a diplomatic option, or some combination.
comment:3 by , 11 years ago
I disagree. Discussion on http://www.wildfiregames.com/forum/index.php ?
comment:4 by , 11 years ago
Note: even if we disagree to implement this for 0 A.D. — Empires Ascendants, it might be useful to be able to have this, modding-wise.
comment:5 by , 9 years ago
Keywords: | design added |
---|
comment:6 by , 9 years ago
Keywords: | patch review added |
---|---|
Milestone: | Backlog → Alpha 19 |
Owner: | set to |
Status: | new → assigned |
Summary: | Implement: Allies share vision an unlocking technology → [Patch] Implement: Allies share vision an unlocking technology |
by , 9 years ago
Attachment: | shared_los.png added |
---|
comment:7 by , 9 years ago
The actual tech is missing from your second patch, but it's in your first, so it doesn't hinder a review (would be nice to get them together in your next patch though).
I have a bit of a bad feeling using ApplyValueModifications for this. The method was meant for numeric template-defined values. Besides, it should always operate on the base value, not on the updated value.
I think it would be better to do something similar to template requirements: Define in the player template how the shared los technology is called, then, when a valuemodification happens, check if that tech is researched, and use that immediately as flag to set the shared los or not.
comment:8 by , 9 years ago
Pretty well done. The only issue I have is, when there's no shared los tech defined for the player, I would assume it keeps the old behaviour (so share los immediately), instead of the current early return.
comment:11 by , 9 years ago
In fact, thinking again to this patch, I'm a bit bothered by the fact that we have to give the name of the tech in the player.xml file and test on this name for applying the tech. That looks a bit as a hack for me
Maybe adding a new propriety in the techs to say that it should apply to the player entity
"playerModifications": [{"value": "Player/SharedLos", "replace": true}],
And add in the player.xml, something like <Player>
<SharedLos>false</SharedLos>
</Player>
would be better, and more flexible for modding.
by , 9 years ago
Attachment: | SharedLOSTechv7.patch added |
---|
Move return up in function and add comment to schema
comment:13 by , 9 years ago
Keywords: | simple design review removed |
---|
comment:15 by , 8 years ago
Summary: | [Patch] Implement: Allies share vision an unlocking technology → [PATCH] Implement: Allies share vision an unlocking technology |
---|
Do both players have to research this for it to work (I think so but it's been some time since I last played AoE)