#2111 closed defect (fixed)
[PATCH] hqdof.fs shader error with GeForce GTX 660 / Win 7
Reported by: | historic_bruno | Owned by: | wraitii |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 17 |
Component: | Core engine | Keywords: | patch |
Cc: | Patch: |
Description
ERROR: Failed to compile shader 'shaders/glsl/hqdof.fs': 0(69) : warning C7583: Initialization of uniform variables requires #version 120 or later 0(122) : warning C7011: implicit cast from "int" to "float" 0(207) : warning C7011: implicit cast from "int" to "float" 0(207) : warning C7011: implicit cast from "int" to "float" 0(221) : warning C7011: implicit cast from "int" to "float" 0(221) : warning C7011: implicit cast from "int" to "float" 0(221) : warning C7011: implicit cast from "int" to "float" 0(225) : warning C7011: implicit cast from "int" to "float" 0(231) : warning C7011: implicit cast from "int" to "float" 0(236) : warning C7011: implicit cast from "int" to "float" 0(236) : warning C7011: implicit cast from "int" to "float" 0(275) : warning C7011: implicit cast from "int" to "float" 0(276) : warning C7011: implicit cast from "int" to "float" 0(278) : warning C7011: implicit cast from "int" to "float" 0(279) : warning C7011: implicit cast from "int" to "float" 0(291) : warning C7011: implicit cast fr...
Attachments (3)
Change History (12)
by , 11 years ago
Attachment: | system_info.txt added |
---|
comment:1 by , 10 years ago
comment:2 by , 10 years ago
Keywords: | patch review added |
---|---|
Milestone: | Backlog → Alpha 16 |
Summary: | hqdof.fs shader error with GeForce GTX 660 / Win 7 → [PATCH] hqdof.fs shader error with GeForce GTX 660 / Win 7 |
Need someone with Nvidia card and drivers to confirm this patch a) fixed the errors and b) doesn't crash as reported on the forum, or if it does, to help debugging.
by , 10 years ago
Attachment: | fix-hqdof-error.patch added |
---|
by , 10 years ago
Attachment: | hqdofFix.patch added |
---|
comment:4 by , 10 years ago
If the issue was the one above this is fixed if it is related to an ogl update it should be pushed to a17
comment:5 by , 10 years ago
Milestone: | Alpha 16 → Alpha 17 |
---|
comment:6 by , 10 years ago
This works also properly for me (on Intel integrated graphics).
I saw on the forums that the technical discussion was discontinued, should the fix be committed anyway? This only applies to the hqdof code, so even if some questioning remains, this patch shouldn't harm much the game :)
comment:7 by , 10 years ago
I chatted with Phillip and wratii on IRC some about this, and they essentially agreed that the whole HQDOF shader is badly broken. It might be best to disable it for now and close this ticket as invalid.
comment:9 by , 8 years ago
Keywords: | review removed |
---|
Another report and WIP patch here: http://www.wildfiregames.com/forum/index.php?showtopic=18356