Opened 11 years ago

Closed 10 years ago

Last modified 8 years ago

#2111 closed defect (fixed)

[PATCH] hqdof.fs shader error with GeForce GTX 660 / Win 7

Reported by: historic_bruno Owned by: wraitii
Priority: Should Have Milestone: Alpha 17
Component: Core engine Keywords: patch
Cc: Patch:

Description

ERROR: Failed to compile shader 'shaders/glsl/hqdof.fs': 0(69) : warning C7583: Initialization of uniform variables requires #version 120 or later 0(122) : warning C7011: implicit cast from "int" to "float" 0(207) : warning C7011: implicit cast from "int" to "float" 0(207) : warning C7011: implicit cast from "int" to "float" 0(221) : warning C7011: implicit cast from "int" to "float" 0(221) : warning C7011: implicit cast from "int" to "float" 0(221) : warning C7011: implicit cast from "int" to "float" 0(225) : warning C7011: implicit cast from "int" to "float" 0(231) : warning C7011: implicit cast from "int" to "float" 0(236) : warning C7011: implicit cast from "int" to "float" 0(236) : warning C7011: implicit cast from "int" to "float" 0(275) : warning C7011: implicit cast from "int" to "float" 0(276) : warning C7011: implicit cast from "int" to "float" 0(278) : warning C7011: implicit cast from "int" to "float" 0(279) : warning C7011: implicit cast from "int" to "float" 0(291) : warning C7011: implicit cast fr...

Attachments (3)

system_info.txt (18.1 KB ) - added by historic_bruno 11 years ago.
fix-hqdof-error.patch (5.1 KB ) - added by historic_bruno 10 years ago.
hqdofFix.patch (2.6 KB ) - added by wraitii 10 years ago.

Download all attachments as: .zip

Change History (12)

by historic_bruno, 11 years ago

Attachment: system_info.txt added

comment:1 by historic_bruno, 10 years ago

comment:2 by historic_bruno, 10 years ago

Keywords: patch review added
Milestone: BacklogAlpha 16
Summary: hqdof.fs shader error with GeForce GTX 660 / Win 7[PATCH] hqdof.fs shader error with GeForce GTX 660 / Win 7

Need someone with Nvidia card and drivers to confirm this patch a) fixed the errors and b) doesn't crash as reported on the forum, or if it does, to help debugging.

by historic_bruno, 10 years ago

Attachment: fix-hqdof-error.patch added

by wraitii, 10 years ago

Attachment: hqdofFix.patch added

comment:3 by wraitii, 10 years ago

Simpler fix, on my HD3000 it works properly.

comment:4 by Stan, 10 years ago

If the issue was the one above this is fixed if it is related to an ogl update it should be pushed to a17

comment:5 by leper, 10 years ago

Milestone: Alpha 16Alpha 17

comment:6 by Itms, 10 years ago

This works also properly for me (on Intel integrated graphics).

I saw on the forums that the technical discussion was discontinued, should the fix be committed anyway? This only applies to the hqdof code, so even if some questioning remains, this patch shouldn't harm much the game :)

comment:7 by Josh, 10 years ago

I chatted with Phillip and wratii on IRC some about this, and they essentially agreed that the whole HQDOF shader is badly broken. It might be best to disable it for now and close this ticket as invalid.

comment:8 by wraitii, 10 years ago

Owner: set to wraitii
Resolution: fixed
Status: newclosed

In 15501:

Remove the HQDOF since it did not really work properly and we already have DOF. Fixes #2111

comment:9 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.