Opened 11 years ago

Last modified 10 years ago

#2118 closed enhancement

[PATCH] Gather version informations into the config files — at Version 6

Reported by: Itms Owned by:
Priority: Should Have Milestone:
Component: Core engine Keywords:
Cc: leper Patch:

Description (last modified by Itms)

The version informations (number and name) are written in the GUI but it would be more convenient gathering it in the code, or in the config files. That makes more simple fixing the splashscreen defect described here : #2116

I've written such a system and modified accordingly the concerned parts of the GUI.

Change History (8)

by Itms, 11 years ago

Attachment: patch_versiondata.diff added

comment:1 by historic_bruno, 11 years ago

The disadvantage of this is that it will require rebuilding the game to change the version information, instead of editing two data files. Perhaps that data could be stored in a config file instead?

comment:2 by Itms, 11 years ago

I don't agree since version information in something developers update when they modifiy the source code. The config files should, IMO, contain data the user can modify (in the future thanks to the 'options' item in the main menu).

The version core information should remain at the heart of the executable file, to be manipulated easily (for example to decide whether to display the splashscreen, but in the future other needs could appear).

Nonetheless, general information such as changelog, or "This is an early version of the game, etc.etc." should definitely be placed in another file (I don't want to change that !).

Last edited 11 years ago by Itms (previous) (diff)

comment:3 by historic_bruno, 11 years ago

Of course developers can rebuild the engine, but part of the design of the engine is to be easily moddable. If we hardcode 0 A.D. version info in the engine, modding requires recompiling the engine - and distributing the new binaries. This is why I say it would be convenient if it was in config (eventually mods can have a mod.cfg file to override default.cfg, this could be useful for lots of things, like data paths).

Config data is as much for flexibility and convenience of developers and modders as it is for players, we simply won't show every config option in-game.

Last edited 11 years ago by historic_bruno (previous) (diff)

comment:4 by fabio, 11 years ago

What about just checking and keeping the date of the news file?

comment:5 by Itms, 11 years ago

Okay, I hadn't thought about the modding-point of view. I hadn't either fully understood the behaviour of the default.cfg file when installing a new version of the game.

I update my previous patch and the ticket description, could you review it and make your point before I modify my patch on #2116 accordingly ?

@fabio : I'm not sure what you meant : the aim of this patch is creating a place where to gather informations which shall be used again in the future development. It permits amongst other things fixing the splashcreen defect.

Last edited 11 years ago by Itms (previous) (diff)

by Itms, 11 years ago

Attachment: patch_versiondata.2.diff added

comment:6 by Itms, 11 years ago

Description: modified (diff)
Summary: [PATCH] Gather version informations into the code[PATCH] Gather version informations into the config files
Note: See TracTickets for help on using tickets.