[PATCH]Small possible memory leak in network/fsm.cpp

[Riemer]

In the function CFsm::AddTransition the pointer to pEvent is lost when allocating pNewTransition fails. Although I doubt the leak will cause a problem when it occurs (the non-allocating will probably cause more havoc), it is atleast something I found after a day worth of digging.

ps. I must add, this is quite a nice codebase! Really educational

Affected sourefile: source/network/fsm.cpp

note: this is based on the git repo

[Riemer]

Patch file, apply in root of 0ad

[historic_bruno]

I think CppCheck or similar report this issue, and it could certainly be a memory leak. I don't know if anyone has ever hit that code path, as you say the leak would be the least problem, but freeing it is technically the correct thing to do.

[ben]

In 13980:

Fixes hypothetical mem leak in network code (and an error in Cppcheck), patch by Riemer, fixes #2122