[PATCH] Content sensitive group icon

[Josef Kufner]

Group buttons at the left edge of the screen have universal icon which only shows number of the group. It woud be more useful to use icon of majority unit in the group. Like a little preview. The number should be visible in the corner of the button.

If there is same amount of units (five elephants and five villagers), the more expensive one should be used first (the elephant icon).

[michael]

Agreed. This would be a nice feature. And the icons don't have to be super specific. There can be a horse/cavalry icon, an infantry icon, a "support" icon, a generic ship icon, etc.

[Josef Kufner]

Adding less specific icons is more work than using icon of major unit in group. And it will make buttons less specific...

[Imarok]

github link: ​https://github.com/Imarok/0ad/tree/2163_content_sensitive_group_icon

[elexis]

In 18728:

Show the portrait of the most common (or most costly) unit type in the selection group buttons on the left hand side. Patch by Imarok, fixes #2163.

[elexis]

Thanks for the patch as usual :)

I made those 2 functions local, since they were not used anywhere else and added a comment. Also made it a template argument of the cost function, so it would be hopefully less confusing (since the group argument you had in there before represents only a subset of the group)

[elexis]

Has some rare, not yet reproducible bug: #4269