Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#2175 closed defect (fixed)

[PATCH] DEBUG is not defined.

Reported by: RefinedCode Owned by: RefinedCode
Priority: Should Have Milestone: Alpha 15
Component: Non-game systems Keywords: Javascript scripting debugger patch
Cc: Yves Patch:

Description (last modified by RefinedCode)

In the javascript debugger, when I stop at a breakpoint, and try to open any of the variable branches in the values tab (locals,this,global) it never loads, and the spinner never goes away. So I opened chrome's developer tools and noticed whenever I try to open a branch, I get the following error:

Uncaught ReferenceError: DEBUG is not defined

This happens in the file source/tools/jsdebugger/js/src/debugger.js at lines:

-222 for the locals branch

-240 for the this branch

-204 for the global branch

Basically all three of those point to the same block of code, just repeated at different places:

error: function(jqXHR, textStatus, errorThrown)
{
	DEBUG(textStatus);
	DEBUG('error');
}

There is a function in the same file called 'debug()' not 'DEBUG()' which would probably be what it's looking for.

So I have created a patch which fixes this error.  A simple fix but I can get used to the patch submission process.  Hopefully I did it right as this is my first time submitting.

Attachments (1)

debugger.js.patch (797 bytes ) - added by RefinedCode 11 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by RefinedCode, 11 years ago

Description: modified (diff)

comment:2 by RefinedCode, 11 years ago

Keywords: debugger added

comment:3 by RefinedCode, 11 years ago

Description: modified (diff)
Keywords: review patch added
Milestone: BacklogAlpha 15
Owner: set to RefinedCode
Summary: [JsDebugger] DEBUG is not defined.[PATCH] DEBUG is not defined.

by RefinedCode, 11 years ago

Attachment: debugger.js.patch added

comment:4 by historic_bruno, 11 years ago

Cc: Yves added

comment:5 by ben, 11 years ago

Resolution: fixed
Status: newclosed

In 13967:

Fixes error logging in the JS debugger, based on patch by RefinedCode. Fixes #2175

comment:6 by historic_bruno, 11 years ago

Keywords: review removed

Thanks for the patch. I made the errors a bit clearer and used the actual messages. I'm not sure why the debugger is broken now :( Nothing has changed on the client side since it last worked, so it must be some server side breakage.

comment:7 by historic_bruno, 11 years ago

Ok, it was r13865 / #2127 that broke the JS debugger.

comment:8 by ben, 11 years ago

In 13973:

Fixes JS debugger, fixes VS 2013 build error, re-fixes #2127, #2175

Note: See TracTickets for help on using tickets.