#2175 closed defect (fixed)
[PATCH] DEBUG is not defined.
Reported by: | RefinedCode | Owned by: | RefinedCode |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 15 |
Component: | Non-game systems | Keywords: | Javascript scripting debugger patch |
Cc: | Yves | Patch: |
Description (last modified by )
In the javascript debugger, when I stop at a breakpoint, and try to open any of the variable branches in the values tab (locals,this,global) it never loads, and the spinner never goes away. So I opened chrome's developer tools and noticed whenever I try to open a branch, I get the following error:
Uncaught ReferenceError: DEBUG is not defined
This happens in the file source/tools/jsdebugger/js/src/debugger.js at lines:
-222 for the locals branch
-240 for the this branch
-204 for the global branch
Basically all three of those point to the same block of code, just repeated at different places:
error: function(jqXHR, textStatus, errorThrown) { DEBUG(textStatus); DEBUG('error'); }
There is a function in the same file called 'debug()' not 'DEBUG()' which would probably be what it's looking for.
So I have created a patch which fixes this error. A simple fix but I can get used to the patch submission process. Hopefully I did it right as this is my first time submitting.
Attachments (1)
Change History (9)
comment:1 by , 11 years ago
Description: | modified (diff) |
---|
comment:2 by , 11 years ago
Keywords: | debugger added |
---|
comment:3 by , 11 years ago
Description: | modified (diff) |
---|---|
Keywords: | review patch added |
Milestone: | Backlog → Alpha 15 |
Owner: | set to |
Summary: | [JsDebugger] DEBUG is not defined. → [PATCH] DEBUG is not defined. |
by , 11 years ago
Attachment: | debugger.js.patch added |
---|
comment:4 by , 11 years ago
Cc: | added |
---|
comment:5 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:6 by , 11 years ago
Keywords: | review removed |
---|
Thanks for the patch. I made the errors a bit clearer and used the actual messages. I'm not sure why the debugger is broken now :( Nothing has changed on the client side since it last worked, so it must be some server side breakage.
In 13967: