Opened 11 years ago

Closed 11 years ago

#2178 closed defect (fixed)

[PATCH] Selections not cleared by quickload

Reported by: historic_bruno Owned by: RefinedCode
Priority: Nice to Have Milestone: Alpha 15
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

To reproduce:

  • Load map
  • Select some units
  • Quick save (Shift+F5)
  • Quick load (shift+F8)

Notice your selection is still active (ignored by the save process), but the selection rings are not visible.

Attachments (1)

session.js.patch​ (464 bytes ) - added by RefinedCode 11 years ago.
Patch to clear selection when quickloading in a game.

Download all attachments as: .zip

Change History (5)

by RefinedCode, 11 years ago

Attachment: session.js.patch​ added

Patch to clear selection when quickloading in a game.

comment:1 by RefinedCode, 11 years ago

I have attached a patch that fixes this problem.

comment:2 by RefinedCode, 11 years ago

Keywords: review patch added
Milestone: Backlog → Alpha 15
Owner: set to RefinedCode
Status: new → assigned
Summary: Selections not cleared by quickload → [PATCH] Selections not cleared by quickload

comment:3 by historic_bruno, 11 years ago

Keywords: review removed

Thanks for the patch. My only comment would be to follow the conventions of the file when you change something: so add a space before the comment and don't put a period at the end of it. The patch works well and since those suggestions are minor, I will make the changes this time :)

comment:4 by ben, 11 years ago

Resolution: → fixed
Status: assigned → closed

In 13981:

Clears selections when loading saved game, patch by RefinedCode (fixes buggy selection behavior when using quicksave/quickload), fixes #2178

Note: See TracTickets for help on using tickets.