[PATCH] Allow setting rally points in mixed selections

[historic_bruno]

Currently, if you select a field and e.g. civ center, you can't set any rally points because the field doesn't allow that. Instead, the civ center should have a rally point set.

We should also think about mixed unit and building selections. Should orders go only to units, or buildings, or both (unit order and rally point)?

[mimo]

Here is a patch which removes some dupplication in getActionInfo and determineAction in gui/session/input.js, so removing quite some useless calls to GetEntityState. I've taken that opportunity to implement the first part of this ticket, i.e. allowing to set rally points even if not all selected buildings have a rally point.

The second part of the ticket needs more discussion/thinking as a same entity could have an order and a rallypoint possible. I don't think it is possible now, but we could for example add an order attack to buildings, or add a rally point to siege units or ships. Depending on such possibilities, the order in which we look for orders and rallypoints have importance.

So this patch keeps the present logic: if at least one unit in the selection, only orders are given; otherwise if at least one entity have rallyPoint, rallyPoints are set.

[leper]

In 13989:

Remove duplication between getActionInfo and determineAction. Allow setting rally points if not all selected buildings can do so. Patch by mimo. Fixes #2189.

[leper]

Thanks for the patch. I'll move the remaining part to a new ticket as that might need some discussion.