Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#2208 closed enhancement (fixed)

[PATCH] Hotkeys for JSDebugger

Reported by: Sathyam M Vellal Owned by: Sathyam M Vellal
Priority: Nice to Have Milestone: Alpha 15
Component: Non-game systems Keywords: patch
Cc: Patch:

Description

The JS Debugger has some control buttons to the right like "Step", "Step into" etc. However, they don't have keybindings/hotkeys. Having one for each button would help.

I've attached the patch below. What I did -

  1. Create a mapping for each button and the keycode.
  2. Create new handler for "keydown".
  3. Call the click handler (which is already defined) if the key is pressed. (Calling the click handler avoids code repetition).

Attachments (1)

jsdebugger-hotkeys.diff (2.3 KB ) - added by Sathyam M Vellal 11 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by Josh, 11 years ago

Patch looks good to me, I'll ask someone to commit it.

comment:2 by Josh, 11 years ago

Keywords: reviewed added; review removed

comment:3 by Josh, 11 years ago

Keywords: reviewed removed

Well, I went ahead and tested it. It seems that adding the ' (F9)' bit on the 'Continue Thread' button causes the text to wrap on the default width. But other than that it works great!

by Sathyam M Vellal, 11 years ago

Attachment: jsdebugger-hotkeys.diff added

comment:4 by Sathyam M Vellal, 11 years ago

Hi Josh, I've increased the default width of the Actions sidebar and updated the diff.

comment:5 by Sathyam M Vellal, 11 years ago

Keywords: review added

comment:6 by Josh, 11 years ago

Keywords: reviewed added; review removed

The new default is a little wide, but should fix the wrapping.

comment:7 by leper, 11 years ago

Resolution: fixed
Status: newclosed

In 14014:

Add hotkeys for JSDebugger commands. Patch by sathyam. Fixes #2208.

comment:8 by leper, 11 years ago

Keywords: reviewed removed

Thanks for the patch.

in reply to:  8 comment:9 by Sathyam M Vellal, 11 years ago

Replying to leper:

Thanks for the patch.

You are welcome, and thank you too!

Note: See TracTickets for help on using tickets.