#2208 closed enhancement (fixed)
[PATCH] Hotkeys for JSDebugger
Reported by: | Sathyam M Vellal | Owned by: | Sathyam M Vellal |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 15 |
Component: | Non-game systems | Keywords: | patch |
Cc: | Patch: |
Description
The JS Debugger has some control buttons to the right like "Step", "Step into" etc. However, they don't have keybindings/hotkeys. Having one for each button would help.
I've attached the patch below. What I did -
- Create a mapping for each button and the keycode.
- Create new handler for "keydown".
- Call the click handler (which is already defined) if the key is pressed. (Calling the click handler avoids code repetition).
Attachments (1)
Change History (10)
comment:1 by , 11 years ago
comment:2 by , 11 years ago
Keywords: | reviewed added; review removed |
---|
comment:3 by , 11 years ago
Keywords: | reviewed removed |
---|
Well, I went ahead and tested it. It seems that adding the ' (F9)' bit on the 'Continue Thread' button causes the text to wrap on the default width. But other than that it works great!
by , 11 years ago
Attachment: | jsdebugger-hotkeys.diff added |
---|
comment:4 by , 11 years ago
Hi Josh, I've increased the default width of the Actions sidebar and updated the diff.
comment:5 by , 11 years ago
Keywords: | review added |
---|
comment:6 by , 11 years ago
Keywords: | reviewed added; review removed |
---|
The new default is a little wide, but should fix the wrapping.
comment:9 by , 11 years ago
Note:
See TracTickets
for help on using tickets.
Patch looks good to me, I'll ask someone to commit it.