#2308 closed defect (fixed)
Add proper license header and tests to hash functions for the lobby
Reported by: | leper | Owned by: | Josh |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 16 |
Component: | Multiplayer lobby | Keywords: | |
Cc: | Patch: |
Description
We should add the proper license header to pbkdf2 and hmac_sha256 from sha.cpp. IIRC those are from OpenBSD.
Those functions also need some tests to verify that they do what they should. (Related: r14123)
Change History (12)
comment:1 by , 10 years ago
comment:3 by , 10 years ago
Milestone: | Alpha 15 → Alpha 16 |
---|---|
Priority: | Release Blocker → Should Have |
comment:5 by , 10 years ago
It'd also be nice to move all of that code somewhere were it makes sense (and it is easily seen that we did take that from somewhere else (like the stuff in third_party)), but that can be done for A16.
comment:7 by , 10 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:9 by , 10 years ago
Is it intentional that the header files are MIT licensed instead of GPL 2 or later? I guess it's not a problem if there's a reason, but it's somewhat out of place inside source/.
comment:11 by , 10 years ago
Thanks for catching that, I changed sha.h to GPL2+ so it matches sha.cpp but I'm going to leave the other header as MIT so it best matches its cpp file.
The tests can wait for Alpha 16. I'll try to straighten out the licence headers tonight.