[PATCH] Graphic settings aren't saved between different executions

[José Manuel Santamaría Lema]

Graphic settings aren't saved after you close the game, so if you had disabled shadows you have had to set that again each time you executed 0AD.

Santa is working on a patch.

[José Manuel Santamaría Lema]

NOTE: in options.xml the code was indented with four spaces, this contradicts the coding conventions explained here ​http://trac.wildfiregames.com/wiki/Coding_Conventions but that was done like that because the entire file is currently indented with four spaces. Also, maybe the code should be moved to a *.js file?

[sanderd17]

The patch works for shadows, but it's quite obvious we would need it for all other settings too. Can you do that?

IMO, it's no good idea to save one setting, and forget another, as it will cause confusion.

[José Manuel Santamaría Lema]

Replying to sanderd17:

The patch works for shadows, but it's quite obvious we would need it for all other settings too. Can you do that?

See the new attached patch 0ad_save_graphics_settings_v2.diff​, is that what you mean? Something else?

IMO, it's no good idea to save one setting, and forget another, as it will cause confusion.

[scythetwirler]

This should be a higher priority, shouldn't it? Our users will be quite confused if the options dialog rests every execution.

[Josh]

Replacing the in-game options menu with the one from the main menu would work best in my opinion.

[JoshuaJB]

In 14967:

Add some more GUI graphics settings while fixing some persistence issues. Refs #2310

[Josh]

Superseded by r15007.