#2354 closed enhancement (fixed)
[PATCH] Camera position is missing in save game
| Reported by: | Michael | Owned by: | Michael |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Alpha 16 |
| Component: | Core engine | Keywords: | save load patch |
| Cc: | Patch: |
Description
If a game is saved and loaded back the camera position is lost.
Attachments (3)
Change History (15)
by , 10 years ago
| Attachment: | save_camera_position.patch added |
|---|
comment:1 by , 10 years ago
| Keywords: | patch review added |
|---|---|
| Milestone: | Backlog → Alpha 16 |
Took me some time to get a clue about the C/JS bridge...but now it's working.
follow-up: 4 comment:2 by , 10 years ago
| Summary: | Camera position is missing in save game → [PATCH] Camera position is missing in save game |
|---|
by , 10 years ago
| Attachment: | save_camera_position_v2.patch added |
|---|
Minor change where in information is saved in the datastructure.
follow-up: 6 comment:3 by , 10 years ago
Thanks for the patch, and sorry for the delay reviewing it. It looks good to me, but may-be we could also save the camera orientation, and not only the position ?
comment:5 by , 10 years ago
Replying to leper:
Replying to boeseRaupe: Any progress?
Currently I don't have time to do anything for the game...
comment:6 by , 10 years ago
Replying to mimo:
Thanks for the patch, and sorry for the delay reviewing it. It looks good to me, but may-be we could also save the camera orientation, and not only the position ?
Yeah, would be a good idea.
comment:8 by , 10 years ago
Thanks boeseRaupe for the initial patch. I've extended it to also save the orientation and the zoom.
comment:9 by , 10 years ago
| Keywords: | review removed |
|---|
follow-up: 11 comment:10 by , 10 years ago
Mimo, when you commit something based on a patch by someone else, it's nice to give credits to the original author in the commit message.
Just a hint for the next time.
comment:11 by , 10 years ago
Replying to sanderd17:
Mimo, when you commit something based on a patch by someone else, it's nice to give credits to the original author in the commit message.
Just a hint for the next time.
I don't mind. I'm glad, if it made it into the game. ;)
Saves the X and Z value of the camera in the savefile and sets camera after game was loaded.