Investigate how the technology "affects" works, should work, and is used

[sanderd17]

See this forum discussion: http://www.wildfiregames.com/forum/index.php?showtopic=18080&hl=

[sanderd17]

The per-modification "affects" is documented as an "OR" function "Melee" AND "Ranged" makes no sense.

It is used only a few times. The ​Mauryan and ​Persian archery tradition uses it. but it doesn't make any sense to use it that way.

Next to that, only the ​heroism and ​soldier will technologies use it to differentiate between the attack types. But this isn't needed either as a "Melee" attack change will never affect a "Ranged" unit and vice versa.

So, I propose to remove the per-modification affects: fixing the templates that use it, remove it from the documentation, and remove it from the code path.

If anyone ever needs a technology that affects a totally different kind of unit, he can always make an auto-researching technology that requires the original technology.

[sanderd17]

remove the per-modification affects

[sanderd17]

In 14930:

Fix how per tech modification affects work + fix the technologies that implement it. Fixes #2366