Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#2375 closed defect (fixed)

[PATCH] AtlasUI compilation failure with wxWidgets 3.0

Reported by: infyquest Owned by: leper
Priority: Should Have Milestone: Alpha 16
Component: Atlas editor Keywords: patch
Cc: Patch:

Description (last modified by sanderd17)

AtlasUI compilation fails with wxWidgets 3.0 with below errors: 

ActorEditor.cpp
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp: In function 'AtObj ConvertToLatestFormat(AtObj)':
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:181:86: error: no matching function for call to 'AtObj::add(const char [9], wxString)'
    out.add(outname, wxString(in["Object"][inname]).Mid(wxString(_T(prefix)).Length()))
                                                                                      ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:188:4: note: in expansion of macro 'THING1'
    THING1(actor,"material", in,"Material", "art/materials/");
    ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:181:86: note: candidates are:
    out.add(outname, wxString(in["Object"][inname]).Mid(wxString(_T(prefix)).Length()))
                                                                                      ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:188:4: note: in expansion of macro 'THING1'
    THING1(actor,"material", in,"Material", "art/materials/");
    ^
In file included from ../../../source/tools/atlas/AtlasUI/General/IAtlasSerialiser.h:21:0,
                 from ../../../source/tools/atlas/AtlasUI/CustomControls/Windows/AtlasWindow.h:23,
                 from ../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.h:18,
                 from ../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:20:
../../../source/tools/atlas/AtlasObject/AtlasObject.h:171:7: note: void AtObj::add(const char*, const wchar_t*)
  void add(const char* key, const wchar_t* value);
       ^
../../../source/tools/atlas/AtlasObject/AtlasObject.h:171:7: note:   no known conversion for argument 2 from 'wxString' to 'const wchar_t*'
../../../source/tools/atlas/AtlasObject/AtlasObject.h:172:7: note: void AtObj::add(const char*, AtObj&)
  void add(const char* key, AtObj& data);
       ^
../../../source/tools/atlas/AtlasObject/AtlasObject.h:172:7: note:   no known conversion for argument 2 from 'wxString' to 'AtObj&'
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:181:86: error: no matching function for call to 'AtObj::add(const char [5], wxString)'
    out.add(outname, wxString(in["Object"][inname]).Mid(wxString(_T(prefix)).Length()))
                                                                                      ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:196:3: note: in expansion of macro 'THING1'
   THING1(var,"mesh",    in,"ModelName",   "art/meshes/");
   ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:181:86: note: candidates are:
    out.add(outname, wxString(in["Object"][inname]).Mid(wxString(_T(prefix)).Length()))
                                                                                      ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:196:3: note: in expansion of macro 'THING1'
   THING1(var,"mesh",    in,"ModelName",   "art/meshes/");
   ^
In file included from ../../../source/tools/atlas/AtlasUI/General/IAtlasSerialiser.h:21:0,
                 from ../../../source/tools/atlas/AtlasUI/CustomControls/Windows/AtlasWindow.h:23,
                 from ../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.h:18,
                 from ../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:20:
../../../source/tools/atlas/AtlasObject/AtlasObject.h:171:7: note: void AtObj::add(const char*, const wchar_t*)
  void add(const char* key, const wchar_t* value);
       ^
../../../source/tools/atlas/AtlasObject/AtlasObject.h:171:7: note:   no known conversion for argument 2 from 'wxString' to 'const wchar_t*'
../../../source/tools/atlas/AtlasObject/AtlasObject.h:172:7: note: void AtObj::add(const char*, AtObj&)
  void add(const char* key, AtObj& data);
       ^
../../../source/tools/atlas/AtlasObject/AtlasObject.h:172:7: note:   no known conversion for argument 2 from 'wxString' to 'AtObj&'
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:201:121: error: no matching function for call to 'AtObj::add(const char [8], wxString)'
    var.add("texture", L"temp/" + wxString(in["Object"]["TextureName"]).Mid(strlen("art/textures/ui/session/portraits/")));
                                                                                                                         ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:201:121: note: candidates are:
In file included from ../../../source/tools/atlas/AtlasUI/General/IAtlasSerialiser.h:21:0,
                 from ../../../source/tools/atlas/AtlasUI/CustomControls/Windows/AtlasWindow.h:23,
                 from ../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.h:18,
                 from ../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:20:
../../../source/tools/atlas/AtlasObject/AtlasObject.h:171:7: note: void AtObj::add(const char*, const wchar_t*)
  void add(const char* key, const wchar_t* value);
       ^
../../../source/tools/atlas/AtlasObject/AtlasObject.h:171:7: note:   no known conversion for argument 2 from 'wxString' to 'const wchar_t*'
../../../source/tools/atlas/AtlasObject/AtlasObject.h:172:7: note: void AtObj::add(const char*, AtObj&)
  void add(const char* key, AtObj& data);
       ^
../../../source/tools/atlas/AtlasObject/AtlasObject.h:172:7: note:   no known conversion for argument 2 from 'wxString' to 'AtObj&'
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:181:86: error: no matching function for call to 'AtObj::add(const char [8], wxString)'
    out.add(outname, wxString(in["Object"][inname]).Mid(wxString(_T(prefix)).Length()))
                                                                                      ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:205:4: note: in expansion of macro 'THING1'
    THING1(var,"texture", in,"TextureName", "art/textures/skins/");
    ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:181:86: note: candidates are:
    out.add(outname, wxString(in["Object"][inname]).Mid(wxString(_T(prefix)).Length()))
                                                                                      ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:205:4: note: in expansion of macro 'THING1'
    THING1(var,"texture", in,"TextureName", "art/textures/skins/");
    ^
In file included from ../../../source/tools/atlas/AtlasUI/General/IAtlasSerialiser.h:21:0,
                 from ../../../source/tools/atlas/AtlasUI/CustomControls/Windows/AtlasWindow.h:23,
                 from ../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.h:18,
                 from ../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:20:
../../../source/tools/atlas/AtlasObject/AtlasObject.h:171:7: note: void AtObj::add(const char*, const wchar_t*)
  void add(const char* key, const wchar_t* value);
       ^
../../../source/tools/atlas/AtlasObject/AtlasObject.h:171:7: note:   no known conversion for argument 2 from 'wxString' to 'const wchar_t*'
../../../source/tools/atlas/AtlasObject/AtlasObject.h:172:7: note: void AtObj::add(const char*, AtObj&)
  void add(const char* key, AtObj& data);
       ^
../../../source/tools/atlas/AtlasObject/AtlasObject.h:172:7: note:   no known conversion for argument 2 from 'wxString' to 'AtObj&'
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:184:76: error: no matching function for call to 'AtObj::add(const char [6], wxString)'
    out.add(outname, wxString(in[inname]).Mid(wxString(_T(prefix)).Length()))
                                                                            ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:217:5: note: in expansion of macro 'THING2'
     THING2(anim,"@file", animit,"@file",  "art/animation/");
     ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:184:76: note: candidates are:
    out.add(outname, wxString(in[inname]).Mid(wxString(_T(prefix)).Length()))
                                                                            ^
../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:217:5: note: in expansion of macro 'THING2'
     THING2(anim,"@file", animit,"@file",  "art/animation/");
     ^
In file included from ../../../source/tools/atlas/AtlasUI/General/IAtlasSerialiser.h:21:0,
                 from ../../../source/tools/atlas/AtlasUI/CustomControls/Windows/AtlasWindow.h:23,
                 from ../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.h:18,
                 from ../../../source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp:20:
../../../source/tools/atlas/AtlasObject/AtlasObject.h:171:7: note: void AtObj::add(const char*, const wchar_t*)
  void add(const char* key, const wchar_t* value);
       ^
../../../source/tools/atlas/AtlasObject/AtlasObject.h:171:7: note:   no known conversion for argument 2 from 'wxString' to 'const wchar_t*'
../../../source/tools/atlas/AtlasObject/AtlasObject.h:172:7: note: void AtObj::add(const char*, AtObj&)
  void add(const char* key, AtObj& data);
       ^
../../../source/tools/atlas/AtlasObject/AtlasObject.h:172:7: note:   no known conversion for argument 2 from 'wxString' to 'AtObj&'
AtlasUI.make:196: recipe for target 'obj/AtlasUI_Release/ActorEditor.o' failed
make[1]: *** [obj/AtlasUI_Release/ActorEditor.o] Error 1
Makefile:80: recipe for target 'AtlasUI' failed
make: *** [AtlasUI] Error 2

Attachments (2)

atlasuifix.patch​ (4.4 KB ) - added by infyquest 10 years ago.
wx30.patch​ (3.3 KB ) - added by leper 10 years ago.
alternate patch

Download all attachments as: .zip

Change History (8)

by infyquest, 10 years ago

Attachment: atlasuifix.patch​ added

comment:1 by infyquest, 10 years ago

Keywords: patch review added

Attached the fix....

comment:2 by sanderd17, 10 years ago

Description: modified (diff)

comment:3 by historic_bruno, 10 years ago

Priority: Release Blocker → Should Have

comment:4 by Michael, 10 years ago

Summary: AtlasUI compilation failure with wxWidgets 3.0 → [PATCH] AtlasUI compilation failure with wxWidgets 3.0

by leper, 10 years ago

Attachment: wx30.patch​ added

alternate patch

comment:5 by leper, 10 years ago

Owner: set to leper
Resolution: → fixed
Status: new → closed

In 14691:

Fix compilation failures with wxWidgets 3.0. Fixes #2375.

comment:6 by leper, 10 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.