Game crash during startup (CSoundManagerWorker::Run)

[phenol]

Normally, the game starts without error but today I received the following msg on startup: Location: unknown:0 (?)

Call stack:

(error while dumping stack: No stack frames found) errno = 0 (No error reported here) OS error = 0 (no error code was set)

[phenol]

crashlog.txt

[phenol]

crashlog.dmp

[historic_bruno]

So it's not reproducible? Seems a bit like #2183 and #2345, not consistently reproducible crashes in the sound manager.

Perhaps it failed to initialize, though I'm not sure how it could get this far without an error:

>	pyrogenesis.exe!CSoundManagerWorker::Run()  Line 141 + 0x6 bytes	C++
 	pyrogenesis.exe!CSoundManagerWorker::RunThread(void * data=0x00457c70)  Line 123	C++
 	pyrogenesis.exe!thread_start(void * param=0x0075eae8)  Line 624 + 0x3 bytes	C++
 	msvcr90.dll!_callthreadstartex()  Line 348 + 0x6 bytes	C
 	msvcr90.dll!_threadstartex(void * ptd=0x0045e400)  Line 326 + 0x5 bytes	C
 	kernel32.dll!@BaseThreadInitThunk@12()  + 0x12 bytes	
 	ntdll.dll!___RtlUserThreadStart@8()  + 0x27 bytes	
 	ntdll.dll!__RtlUserThreadStart@8()  + 0x1b bytes	

(the dump indicates that g_SoundManager is a NULL pointer)

[wraitii]

Also similar to #2317. Definitely a NULL pointer issue.

[historic_bruno]

Duplicate of #2333.

[ben]

In 15269:

Fixes rare crash in sound manager, due to worker thread dereferencing global pointer before it had been assigned. Fixes #2333, refs #2387, #2317.
Fixes potential infinite loop if worker thread was running but not enabled.
Fixes apparent bug in fading sound smoothness.
Cleans up worker class slightly.
Cleans up weird and inconsistent whitespace.