Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#2474 closed enhancement (fixed)

[PATCH] Raise alert positioning

Reported by: rogue-spectre Owned by: Itms
Priority: Nice to Have Milestone: Alpha 19
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

I enjoy the new raise/increase alert buttons. I think would be even better with little modification.

1 - align buttons in order when "raise alert" is pressed the "increase alert level" is positioned at the exact same place as "raise alert" was in order to save time when the enemy is coming.

2 - move the position of the end alert in order it's not under "increase alert level" to avoid canceling the previous order by over clicking to raise alert.

3 - change a little the color of the "increased alert level"

Attachments (6)

alert_raise.patch (4.1 KB ) - added by rogue-spectre 9 years ago.
bell_level_min.png (1.8 KB ) - added by rogue-spectre 9 years ago.
bell for minimum level of threat
bell_level_max.png (1.9 KB ) - added by rogue-spectre 9 years ago.
bell for maximum level of threat
bell_level2.png (1.8 KB ) - added by rogue-spectre 9 years ago.
bell for level 2 of threat
alert_raise_03122014.patch (1.6 KB ) - added by rogue-spectre 9 years ago.
display alert button and end alert button
alert-buttons.patch (6.0 KB ) - added by Itms 9 years ago.

Download all attachments as: .zip

Change History (21)

comment:1 by Marcio, 10 years ago

Nice catch, I'm feeling same.

comment:2 by Stan, 10 years ago

Resolution: invalid
Status: newclosed

Invalid since Pureon is reworking on it.

Last edited 10 years ago by Stan (previous) (diff)

comment:3 by sanderd17, 10 years ago

Milestone: Alpha 16

by rogue-spectre, 9 years ago

Attachment: alert_raise.patch added

by rogue-spectre, 9 years ago

Attachment: bell_level_min.png added

bell for minimum level of threat

by rogue-spectre, 9 years ago

Attachment: bell_level_max.png added

bell for maximum level of threat

by rogue-spectre, 9 years ago

Attachment: bell_level2.png added

bell for level 2 of threat

comment:4 by rogue-spectre, 9 years ago

Hi again, just created a patch to improve this. It might be temporary but i think it is better like this.

I was wondering if it was a good idea to merge the two icons and use right click to decrease the level of alert… I did not find how to use right click for now.

Pictures go in /binaries/data/mods/public/art/textures/ui/session/icons.

comment:5 by rogue-spectre, 9 years ago

Summary: raise alert positionning[PATCH] raise alert positionning

comment:6 by rogue-spectre, 9 years ago

Resolution: invalid
Status: closedreopened

comment:7 by rogue-spectre, 9 years ago

Milestone: Alpha 18

by rogue-spectre, 9 years ago

Attachment: alert_raise_03122014.patch added

display alert button and end alert button

comment:8 by Itms, 9 years ago

Hey, please follow these rules when submitting patches: SubmittingPatches This avoids losing your code inside the huge lot of tickets :)

comment:9 by scythetwirler, 9 years ago

Summary: [PATCH] raise alert positionning[PATCH] Raise alert positioning

comment:10 by Itms, 9 years ago

Keywords: review patch added; raise alert positionning removed

comment:11 by Itms, 9 years ago

Milestone: Alpha 18Alpha 19

comment:12 by Itms, 9 years ago

Owner: set to Itms
Status: reopenednew

Hi, I finally took some time to write myself a patch.

Your patch can't be committed because we lack space in the unit commands panel and having a disabled button in it for 95% of the time was just not an option.

As a solution, I propose moving the alert buttons to the garrison panel. Tell me if it suits your needs as a player.

by Itms, 9 years ago

Attachment: alert-buttons.patch added

comment:13 by rogue-spectre, 9 years ago

Hi,

I tested your patch yesterday. The position is ok for the two other players of Ageof i asked to and me. The only thing to add ( and the other players agreed ) would be to have a difference between the bell for increasing the level once and the bell for increasing the level twice, in order the level of alert is more obvious. In the patched i previously wrote i used the existing yellow bell for increasing once and a modified red bell for increasing twice, you could use it, and the patch would be 100% ok for me.

comment:14 by Itms, 9 years ago

Resolution: fixed
Status: newclosed

In 16670:

Enhance the alert buttons by moving them to the garrisoning panel. Also add a new icon for the maximum level of alert.

Suggestion and testing by rogue-spectre, fixes #2474.

comment:15 by Itms, 9 years ago

Keywords: review removed

Thanks for testing and giving feedback! I improved my patch a bit by hiding disabled buttons. I also used an icon I made instead of yours for the maximum level, because I wanted to have a more realistic icon. I hope you don't mind :)

Note: See TracTickets for help on using tickets.