[PATCH] Gather mod informations and configuration

[Itms]

Based on my old #2118 patch, I propose this one, aimed at gathering mod data in a file at the root of the mod. The system should be general enough to suit every mod. Please give me feedback about it!

[gallaecio]

In 15001:

Added support for message extraction from INI files

Refs #2487

[Adrián Chaves]

Internationalization notes:

• As we spoke on IRC, extract the font tags outside:

  sprintf(translate("[font=\"sans-bold-16\"]%(versionName)s: %(versionNickname)s[/font]\n\n")
  

  to

  "[font=\"sans-bold-16\"]" + sprintf(translate(%(versionName)s: %(versionNickname)s") + "[font=\"sans-bold-16\"]"
  

• Add the following to the messages.json file to extract the keys of the INI file:

  {
      "extractor": "ini",
      "filemasks": [
          "config/public.cfg"
      ],
      "options": {
          "format": "none",
          "keywords": [
              "title",
              "version.name",
              "version.nickname",
              "version.number"
          ]
      }
  },
  

• Translate those keywords in display strings. For example, change:

  {versionName: Engine.ConfigDB_GetValue("mod", "version.name"), versionNickname: Engine.ConfigDB_GetValue("mod", "version.nickname")} 
  

  to

  {versionName: translate(Engine.ConfigDB_GetValue("mod", "version.name")), versionNickname: translate(Engine.ConfigDB_GetValue("mod", "version.nickname"))} 
  

PS: I’m glad that we can get rid of those ugly keep/translate XML tags here.

[Itms]

Updated the patch to use Gallaecio's improvements and cleaned up the organization of new files.

[Adrián Chaves]

getVersionLabel() is also missing translate() calls for its parameters.

[Itms]

Indeed, sorry for the oversight :(

[sanderd17]

What happens when multiple mods are loaded?

Is this still a valid ticket, or are there better approaches? I know you discussed with leper, but I didn't follow the discussions.

[Radagast]

sander mentioned in another ticket that the same file in a mod can't be overriden more than once.

If multiple overwriting in a row worked then - when loading multiple mods - the last loaded mod that provides a info.cfg would get used for the ingame mod information in the main menu.

[leper]

Overriding a file in different mods works just fine (it uses the file in the last mounted mod) (or the last mounted mod that has the file).

[Itms]

Pushing this for leper's eyes only. The attached patch is in any case invalid due to r15676 et al.

[leper]

Most of what this ticket tried to solve is done using the mod.json files now. Everything that is left can be done by adding some files to a mod (version display). Having a mod specific config file might be useful at some point, but will probably give some issues with having two mods which both need some settings, and should be done in another ticket.