Need to send units to attack twice

[Adrián Chaves]

​https://www.youtube.com/watch?v=6wx_CawlUkw

I select my units, right-click on the enemy, and wait. My units approach and stop. I have to right-click on the enemy again then for them to start attacking.

[Niek]

I think it has to do with priorities. F.e. when you move your soldiers while they were near a enemy building you have issue the order more than once too.

[sanderd17]

In 15054:

Fix formations attacking by adding a combat.approaching state. Fixes #2496