#2529 closed defect (fixed)
[PATCH] Having more than one observer crashes
Reported by: | Josh | Owned by: | Josh |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 17 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | scythetwirler | Patch: |
Description
Having more than one observer in a multiplayer game can frequently crash due to incorrect initial assignment of any observer in CNetServerWorker::AddPlayer (source:ps/trunk/source/network/NetServer.cpp#L609).
Possible solutions are initially assigning all joining players the ID -1 in the network code and allowing gamesetup to correct as needed. Or the network code could try to determine if a player should be an observer or not.
Attachments (1)
Change History (9)
comment:2 by , 10 years ago
Keywords: | review patch added |
---|---|
Summary: | Having more than one observer crashes → [PATCH] Having more than one observer crashes |
I've attached a patch following my first idea for a solution (assign the player ID in gamesetup) which seems to work in limited local testing.
by , 10 years ago
Attachment: | fix-multiobserver.diff added |
---|
Fix crash by assigning new player IDs in gamesetup.
comment:3 by , 10 years ago
Milestone: | Alpha 16 → Alpha 17 |
---|
comment:4 by , 10 years ago
Leper reviewed the patch and I've responded to his suggestions. I'll commit this tomorrow if there are no objections.
comment:6 by , 8 years ago
Keywords: | review removed |
---|
maybe an enum with player types