Warnings flood when playing with the camera

[serveurix]

On many maps when I play with the camera (mostly when I deactivate "restrict camera" in the dev overlay and go over an area of a different altitude), the screen is filled up with "warning: SpatialSubdivision Query too large. Results truncated." This is particularly annoying since you can't prevent those messages to be displayed, and, you know, when you play with the camera, usually it's to take captures...

One simple way to reproduce this bug is to choose the first acropolis skrimish map, reveal the map, unrestrict the camera, and move to the center of the map.

[leper]

IIRC this is related to #2430.

[serveurix]

Replying to leper:

IIRC this is related to #2430.

Ok, so the problem existed before, and the warnings appear because of the new Spidermonkey ?

[leper]

No, this is not related to JS at all. It occurs because r13854 introduced a fixed limit for SpatialSubdivision queries, and even though r13888 bumped that fixed limit #2340 is still a better solution to that IMO.

[Josh]

These are because of r14532 which starts requesting two times more data from SpatialSubdivision if the camera is unlocked. (See session.xml changes)

[historic_bruno]

Replying to leper:

No, this is not related to JS at all. It occurs because r13854 introduced a fixed limit for SpatialSubdivision queries, and even though r13888 bumped that fixed limit #2340 is still a better solution to that IMO.

Can today be the day someone reverts them? Hopefully there wouldn't be too many conflicts. It should have been done for A16.

[Philip Taylor]

Something like that? (Just did a revert and fixed the conflicts in the obvious ways. Not tested much, and not tested performance at all.)

[wraitii]

In 15617:

Revert RedFox's changes to Spatial subdivisions in the simplest possible way (hopefully won't cause OOS, but at least we'll get reports). Fixes #2573, Refs #2430 . There probably are opportunities to remove more things.

[Stan]

Will that have an impact on performance ?