Opened 15 years ago

Closed 15 years ago

Last modified 12 years ago

#265 closed defect (fixed)

[Mac OS X] premake fails to include libxml2 with threadding enabled

Reported by: espes Owned by:
Priority: Should Have Milestone: Pre-Alpha 1
Component: Core engine Keywords: mac premake libxml2
Cc: Simon Brenner Patch:

Description

libxml2 checks for thread support by not only checking if it was compiled in, but also by checking whether "_REENTRANT" or "MT" is set. Usually, AFAIK, these are set on *nix when pthread is included, but since on OS X GNU threads are included in libSystem, this does not happen.

I propose the attached fix, but if anyone has a better idea, feel free.

Attachments (1)

fix.diff​ (612 bytes ) - added by espes 15 years ago.
exter_libs.lua patch

Download all attachments as: .zip

Change History (7)

by espes, 15 years ago

Attachment: fix.diff​ added

exter_libs.lua patch

comment:1 by espes, 15 years ago

Damn markdown. That should be "__MT__"

comment:2 by Simon Brenner, 15 years ago

Cc: Simon Brenner added

Hmm, sounds like something that pkg-config should handle for us. Does your "pkg-config libxml-2.0 --cflags" list the required define? (I don't see it on any of my systems, but that could be that my libxml installs weren't configured for threadedness)

comment:3 by espes, 15 years ago

"pkg-config libxml-2.0 --cflags" just returns the include on my system. AFAIK, thread safety is a default cofig option in libxml2, and it is enabled in both the version OS X comes with, and the version from macports.

comment:4 by Philip Taylor, 15 years ago

Resolution: → fixed
Status: new → closed

Should be fixed in r7078. Thanks!

comment:5 by (none), 14 years ago

Milestone: Open Source Release

Milestone Open Source Release deleted

comment:6 by historic_bruno, 12 years ago

Milestone: → Pre-Alpha 1
Note: See TracTickets for help on using tickets.