Ticket #265 (closed defect: fixed)

Opened 4 years ago

Last modified 14 months ago

[Mac OS X] premake fails to include libxml2 with threadding enabled

Reported by: espes Owned by:
Priority: Should Have Milestone: Pre-Alpha 1
Component: Core engine Keywords: mac premake libxml2
Cc: olsner

Description

libxml2 checks for thread support by not only checking if it was compiled in, but also by checking whether "_REENTRANT" or "MT" is set. Usually, AFAIK, these are set on *nix when pthread is included, but since on OS X GNU threads are included in libSystem, this does not happen.

I propose the attached fix, but if anyone has a better idea, feel free.

Attachments

fix.diff​ (612 bytes) - added by espes 4 years ago.
exter_libs.lua patch

Change History

Changed 4 years ago by espes

exter_libs.lua patch

comment:1 Changed 4 years ago by espes

Damn markdown. That should be "__MT__"

comment:2 Changed 4 years ago by olsner

  • Cc olsner added

Hmm, sounds like something that pkg-config should handle for us. Does your "pkg-config libxml-2.0 --cflags" list the required define? (I don't see it on any of my systems, but that could be that my libxml installs weren't configured for threadedness)

comment:3 Changed 4 years ago by espes

"pkg-config libxml-2.0 --cflags" just returns the include on my system. AFAIK, thread safety is a default cofig option in libxml2, and it is enabled in both the version OS X comes with, and the version from macports.

comment:4 Changed 4 years ago by Philip

  • Status changed from new to closed
  • Resolution set to fixed

Should be fixed in r7078. Thanks!

comment:5 Changed 3 years ago by anonymous

  • Milestone Open Source Release deleted

Milestone Open Source Release deleted

comment:6 Changed 14 months ago by historic_bruno

  • Milestone set to Pre-Alpha 1
Note: See TracTickets for help on using tickets.