Opened 10 years ago
Closed 9 years ago
#2672 closed defect (fixed)
Allow enabling post processing effects in-game
Reported by: | Adomas Jackevičius | Owned by: | Itms |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 18 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: |
Description
Hello,
After installing 0 A.D. on Arch Linux when I launched it I set graphics options what I call to "max" and when I entered game it was BLACK SCEEEN. I got confused. Disabling one by one options in Graphics Options menu I found out that Post Processing causes the trouble. To enable Post Processing I had to restart the game, but the tooltip did not mention that. Not sure if it's a bug, but it should reload the engine so it displays correctly after settings change or smth.
Running Arch Linux x86_64 on GTX 780 GPU
Attachments (1)
Change History (14)
comment:1 by , 10 years ago
Keywords: | unanswered added |
---|
by , 10 years ago
Attachment: | PostProc_v1.patch added |
---|
comment:3 by , 10 years ago
Keywords: | review patch added; unanswered removed |
---|---|
Summary: | Black Screen on Linux → [PATCH] Black Screen on Linux |
comment:5 by , 10 years ago
Milestone: | Backlog → Alpha 17 |
---|
Don't forget to update the milestone. I didn't look at the patch at all, so I'll just put A17 and if it's not trivial we'll push it later.
comment:7 by , 10 years ago
The patch works for me on Windows 7. Need to take a look at the code to see if it initializes/shuts down cleanly, if so we can commit it.
comment:8 by , 10 years ago
Summary: | [PATCH] Black Screen on Linux → [PATCH] Black Screen / Errors when enabling post processing effects in-game |
---|
#2561 was also a duplicate of this.
comment:10 by , 10 years ago
Component: | Core engine → UI & Simulation |
---|---|
Keywords: | review patch removed |
Milestone: | Alpha 17 → Alpha 18 |
Priority: | Should Have → Nice to Have |
Summary: | [PATCH] Black Screen / Errors when enabling post processing effects in-game → [STRING] Allow enabling post processing effects in-game |
Thanks for that patch!
I reopen it and push it because I'll have to update a string once the release is over. The fix is included for A17 though, along with the code updates.
comment:11 by , 10 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:13 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Summary: | [STRING] Allow enabling post processing effects in-game → Allow enabling post processing effects in-game |
Ugh, seems like everybody had forgotten this one :)
PostProc_v1.patch fixes this. It was an initialization bug like the LOS bug from #2513.
Works by calling the Initialization routine whenever a public routine is called.
void CPostprocManager::Resize() is the exception. It will only recreate the buffers if the buffers are active. That way the current screen size is always correct without unwanted buffer updates.
void CPostprocManager::Cleanup() - moved to private
std::vector<CStrW> CPostprocManager::GetPostEffects() - changes fron const to static