#2859 closed enhancement (fixed)
[PATCH] sprintf.js - Out of date
Reported by: | Shane Grant | Owned by: | Itms |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 18 |
Component: | Internationalization & Localization | Keywords: | |
Cc: | Patch: |
Description
It doesn't appear that any changes to Alexei's sprintf.js since 2010 have been implemented, and in particular there was a change in May of this year that increased the performance by 20%. See:
https://github.com/alexei/sprintf.js/issues/6
Attached is a patch updating to the current version from Github:
https://github.com/alexei/sprintf.js
In the patch I added the current license to the top so it is in the same file.
Attachments (1)
Change History (5)
by , 10 years ago
Attachment: | sprintf-update.diff added |
---|
comment:1 by , 10 years ago
Keywords: | patch review added |
---|---|
Milestone: | Backlog → Alpha 18 |
Summary: | sprintf.js - Out of date → [PATCH] sprintf.js - Out of date |
comment:4 by , 10 years ago
Component: | UI & Simulation → I18n & L10n |
---|---|
Keywords: | patch review removed |
Thanks for carrying out that update, Shane! I only updated the version number in the sprintf.js file, to follow the recent tagging of the github repo.
Note:
See TracTickets
for help on using tickets.
Please follow SubmittingPatches when doing so.
Also note that a performance improvement in IE doesn't really matter for us, updating the code is more of a reason.