Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#2859 closed enhancement (fixed)

[PATCH] sprintf.js - Out of date

Reported by: Shane Grant Owned by: Itms
Priority: Should Have Milestone: Alpha 18
Component: Internationalization & Localization Keywords:
Cc: Patch:

Description

It doesn't appear that any changes to Alexei's sprintf.js since 2010 have been implemented, and in particular there was a change in May of this year that increased the performance by 20%. See:

https://github.com/alexei/sprintf.js/issues/6

Attached is a patch updating to the current version from Github:

https://github.com/alexei/sprintf.js

In the patch I added the current license to the top so it is in the same file.

Attachments (1)

sprintf-update.diff (15.6 KB ) - added by Shane Grant 10 years ago.

Download all attachments as: .zip

Change History (5)

by Shane Grant, 10 years ago

Attachment: sprintf-update.diff added

comment:1 by leper, 10 years ago

Keywords: patch review added
Milestone: BacklogAlpha 18
Summary: sprintf.js - Out of date[PATCH] sprintf.js - Out of date

Please follow SubmittingPatches when doing so.

Also note that a performance improvement in IE doesn't really matter for us, updating the code is more of a reason.

comment:2 by Shane Grant, 10 years ago

Thanks leper for pointing me to that link, I had not seen it obviously.

comment:3 by Itms, 10 years ago

Owner: set to Itms
Resolution: fixed
Status: newclosed

In 15916:

Update sprintf.js to the latest version 1.0.2 (https://github.com/alexei/sprintf.js).

Update suggested and patch generated by Shane, fixes #2859.

comment:4 by Itms, 10 years ago

Component: UI & SimulationI18n & L10n
Keywords: patch review removed

Thanks for carrying out that update, Shane! I only updated the version number in the sprintf.js file, to follow the recent tagging of the github repo.

Note: See TracTickets for help on using tickets.