Opened 10 years ago

Closed 9 years ago

#2866 closed defect (fixed)

[PATCH]Alignment error in German stats screen

Reported by: Raymond Owned by: Jaison
Priority: Should Have Milestone: Alpha 18
Component: UI & Simulation Keywords: patch
Cc: marcotomsuden@… Patch:

Description

buildings > "Verwaltungssitz"

market > "Tauscheffizienz" and "Handelseinkommen"

So please make the stats wider

Attachments (4)

stats1.jpg (166.4 KB ) - added by Raymond 10 years ago.
stats2.jpg (154.2 KB ) - added by Raymond 10 years ago.
summary.js (34.7 KB ) - added by Jaison 10 years ago.
Fixed version of Summary.js
summary.js.patch (3.8 KB ) - added by Jaison 10 years ago.
I have add summary patch.

Download all attachments as: .zip

Change History (11)

by Raymond, 10 years ago

Attachment: stats1.jpg added

by Raymond, 10 years ago

Attachment: stats2.jpg added

in reply to:  description comment:1 by Jaison, 10 years ago

Replying to raymond:

buildings > "Verwaltungssitz"

market > "Tauscheffizienz" and "Handelseinkommen"

So please make the stats wider

Can I fix this?

Greetings Jaison

comment:2 by Jaison, 10 years ago

I have fixed this ;-)

Please check after this if further problems arise, you like to contact me.

If I can help with other faults please contact, no matter what I do that.

Greetings Jaison

PS: I have no option to svn commit, no access.

That's why I hang the file as notes.

by Jaison, 10 years ago

Attachment: summary.js added

Fixed version of Summary.js

comment:3 by Itms, 10 years ago

Hello Jaison, this is not the way contributors should propose modifications. I suggest you read SubmittingPatches and carry on with fixing the problem reported here. Using patches also allows us to see more clearly what changes you propose, here I just can't know quickly what you changed in the file.

Don't hesitate to ask for precisions, or drop by #0ad-dev on QuakeNet! Thanks for working on that bug.

by Jaison, 10 years ago

Attachment: summary.js.patch added

I have add summary patch.

comment:4 by Jaison, 10 years ago

Cc: marcotomsuden@… added
Keywords: review patch added
Milestone: BacklogAlpha 18
Owner: set to Jaison
Status: newassigned
Summary: Alignment error in German stats screen[PATCH]Alignment error in German stats screen

comment:5 by leper, 9 years ago

Keywords: review removed
Resolution: fixed
Status: assignedclosed

Fixed by changing the translations a bit. The patch has some issues on 1024x768 with other languages otherwise. Would be nice to adjust the sizes of the headings and actual values according to the screen size though.

comment:6 by Raymond, 9 years ago

Resolution: fixed
Status: closedreopened

according to: https://www.netmarketshare.com/report.aspx?qprid=17 http://www.w3counter.com/globalstats.php

the resolution of 1024x768 use only 9%.

So please increase requirement to at least 1366x768 (21%).

Last edited 9 years ago by Raymond (previous) (diff)

comment:7 by Itms, 9 years ago

Resolution: fixed
Status: reopenedclosed

Why would we do that? We still have a significant part of users that run the game under that resolution. Anyway, if you want to discuss this, this is not the right place because the ticket is unrelated.

Note: See TracTickets for help on using tickets.