Opened 9 years ago
Last modified 5 years ago
#2982 new defect
[PATCH] The "preserve match settings" should also save player-assignments
Reported by: | mimo | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Backlog |
Component: | UI – Game setup | Keywords: | patch |
Cc: | Patch: |
Description
Take a 2-player skirmish map, choose to play as player 2, then quit. When back to the game selection window, the player is back as player 1 and player 2 is unassigned.
Attachments (1)
Change History (16)
comment:1 by , 9 years ago
Summary: | The "preserve match seetings" sets player 2 unassigned after playing as player 2 → The "preserve match settings" sets player 2 unassigned after playing as player 2 |
---|
comment:2 by , 9 years ago
comment:4 by , 9 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
by , 9 years ago
Attachment: | preserveSettingsFix.patch added |
---|
Not the best approach but it's working now.
comment:5 by , 9 years ago
Keywords: | review added |
---|
comment:6 by , 9 years ago
Priority: | Nice to Have → Should Have |
---|---|
Summary: | The "preserve match settings" sets player 2 unassigned after playing as player 2 → [PATCH] The "preserve match settings" sets player 2 unassigned after playing as player 2 |
comment:7 by , 9 years ago
Keywords: | patch added |
---|---|
Milestone: | Backlog → Alpha 18 |
comment:8 by , 9 years ago
Keywords: | review removed |
---|---|
Milestone: | Alpha 18 → Alpha 19 |
comment:9 by , 9 years ago
Milestone: | Alpha 19 → Alpha 20 |
---|
comment:10 by , 9 years ago
Owner: | removed |
---|---|
Status: | assigned → new |
comment:12 by , 8 years ago
Keywords: | review added |
---|---|
Milestone: | Backlog → Alpha 21 |
Priority: | Should Have → Nice to Have |
An apparently working patch can be found at #3804
comment:13 by , 8 years ago
Keywords: | review removed |
---|---|
Milestone: | Alpha 21 → Backlog |
Summary: | [PATCH] The "preserve match settings" sets player 2 unassigned after playing as player 2 → [PATCH] The "preserve match settings" should also save player-assignments |
The fundamental problem is that the persistmatchsettings doesn't save the playerassignments (only save the playerdata, which includes AI settings and civs).
Saving playerassignments is something which would also help with rehosting, but has to be taken care of properly. Whomever changes this will have to ensure that the file not only grow but also shrinks (i.e. also delete assignments instead of only adding assignments inbetween games) and that the game doesn't break when trying to load matchsettings of an older version of 0AD.
Notice g_PlayerAssignments
is saved in gamesetup.js
and m_PlayerAssignments
in NetServer.cpp
.
comment:15 by , 5 years ago
Component: | UI & Simulation → Game setup |
---|
Move tickets to Game Setup
as UI & Simulation
got some sub components.
This is a (at least to me) known behaviour :P
I guess I'll just apply AIs to previously non-AI being slots.