Opened 9 years ago

Closed 9 years ago

#3018 closed enhancement (fixed)

[PATCH]Deleting saved game without confirmation

Reported by: mimo Owned by:
Priority: Should Have Milestone: Alpha 18
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

When we want to remove several saved games, it is a bit tedious to always have the confirmation window. It would be nice to have a hotkey (Suppr key) to avoid the confirmation.

Attachments (2)

saved.diff (2.1 KB ) - added by mimo 9 years ago.
saved-v2.diff (2.6 KB ) - added by mimo 9 years ago.
new version following leper's suggestion

Download all attachments as: .zip

Change History (17)

by mimo, 9 years ago

Attachment: saved.diff added

comment:1 by leper, 9 years ago

Shift+Del would be a better hotkey, with Del only also having the confirmation dialog.

comment:2 by Philip Taylor, 9 years ago

Or just always delete without any confirmation, and then have an "undo" button in case you made a mistake? (so "delete" would really mean "move to a kind of Recycle Bin directory, so it won't show up in the list, and then detect any recycled files older than a couple of days and automatically delete them for real")

by mimo, 9 years ago

Attachment: saved-v2.diff added

new version following leper's suggestion

comment:3 by mimo, 9 years ago

In 16236:

add hotkey for deleting saved games, addresses #3018

comment:4 by mimo, 9 years ago

Keywords: review removed
Resolution: fixed
Status: newclosed

comment:5 by mimo, 9 years ago

In 16239:

update online manual, refs #3018

comment:6 by fabio, 9 years ago

It would be nice if this would also work when pressing shift key + delete window button (other than delete key only).

comment:7 by mimo, 9 years ago

In 16245:

Shift key when deleting a saved game do not need confirmation, addresses #3018

comment:8 by fabio, 9 years ago

Thanks. Sorry for nitpicking again, but would be possible to have a single config option for the "no need to confirm" option? If you did it that way I suppose it's not easy and so you defined two separate options for the reallyDelete and noConfirmation?

comment:9 by mimo, 9 years ago

Yes, in fact the reallyDelete config (and the code using it) is now useless, I forgot to remove it. I'll do it in a next commit.

comment:10 by mimo, 9 years ago

fixed in r16251

comment:11 by fabio, 9 years ago

Resolution: fixed
Status: closedreopened

Hi, I changed the noconfirmation key to Alt and it works when using the delete key, but not when pressing the delete button.

Also, intro.txt should be updated.

comment:12 by mimo, 9 years ago

Yes, some keys are not understood. I've tried with Ctrl also and there, we have the opposite configuration: it works when pressing the delete button, but not when using the delete key. I suppose something else intercepts these keys.

comment:13 by fabio, 9 years ago

I can confirm, if you think this is a problem not specific to this issue this could be closed (and maybe another ticket opened for it). Thanks.

comment:14 by mimo, 9 years ago

Yes, I agree that a more specific ticket would be better to follow this issue.

in reply to:  14 comment:15 by fabio, 9 years ago

Resolution: fixed
Status: reopenedclosed

Replying to mimo:

Yes, I agree that a more specific ticket would be better to follow this issue.

Reported in #3034.

Note: See TracTickets for help on using tickets.