Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3082 closed defect (fixed)

Grame crash

Reported by: fexx Owned by: ben
Priority: Release Blocker Milestone: Alpha 18
Component: Core engine Keywords:
Cc: Patch:

Description

Alpha 18 RC crashed during single player game.

Log is attached.

Attachments (1)

logfile.txt (13.9 KB ) - added by fexx 9 years ago.
Logfile

Download all attachments as: .zip

Change History (8)

by fexx, 9 years ago

Attachment: logfile.txt added

Logfile

comment:1 by fexx, 9 years ago

Windows 8.1

comment:2 by historic_bruno, 9 years ago

Thanks for testing! Were you using healers? The action-heal cursor can't be loaded by the game anymore (since r16386?) A quick check in Gimp shows it has indexed color, and that's not supported by the engine. I also notice test-old is now grayscale, that would fail too.

comment:3 by Stan, 9 years ago

Do you want me to submit a fixed icon ?

comment:4 by fabio, 9 years ago

The greyscale and indexed colors are likely caused by the optipng pass I did after the imagemagick trick to remove garbage from PNG. If someone can (I cannot for some days) it should check it and eventually reapply the imagemagick trick from old file, omitting optipng run, while advdef can still be executed, it just improve deflate compression.

comment:5 by ben, 9 years ago

Owner: set to ben
Resolution: fixed
Status: newclosed

In 16407:

Reverts action-heal cursor from r16386, it was modified to indexed color not currently supported by the engine, fixes #3082, refs #1640. Reapplies the transparent color removal, refs #2823.
Deletes unused test-old cursor

comment:6 by historic_bruno, 9 years ago

In fact, the imagemagick command outputs an indexed PNG, so I couldn't even use it. For now, that cursor will be broken as far as #2823 is concerned, at least it won't crash.

comment:7 by ben, 9 years ago

In 16439:

Improves handling of PNG textures based on GdkPixbuf's setup_png_transformations. The PNG decoder should now support grayscale, RGB or indexed color; bit depth up to 16; and interlacing. Fixes #1640, refs #2823, #3082

Note: See TracTickets for help on using tickets.