[PATCH] Builders do not deposit after finishing building a dropsite

[Kalle Richter]

Builders carrying some resource type that can be deposited at the constructed dropsite should deposit their resources.

[sanderd17]

The patch does not work when you queue an order. Steps to reproduce:

• Make sure your units are carrying some resources
• Let them build a dropsite, and queue gathering a resource (not the nearest resource, so you clearly see the queued order gets executed).
• When the units have build the dropsite, they'll walk towards the queued target, without first dropping the resources

I think you could use "PushOrderFront" instead of just "PushOrder", to bypass the queue. But testing this behaviour is needed.

[maveric]

Thanks for reply. There is no point of usage PushOrderFront instead of PushOrder in 2690 line because order queue is empty anyway.

[maveric]

Now it works when there are queued orders.

[maveric]

Changed 'if' statement according to coding conventions.

[sanderd17]

In 16581:

Drop off resources when building dropsite. Patch by maveric. Fixes #3093