[PATCH] Find idle trade carts with hotkey

[elexis]

Sometimes your trade carts become idle, for example if a market is destroyed. But if you already have many trade carts on multiple trade routes, then you have a hard time finding those idle trade carts. Even if you find them easily, you might have a hard time selecting all of them, since you need to select them individually and try not to select non-idle trade carts.

While you can see the number of idle trade carts in the trade menu, there is no way to find them except looking over all trade routes you ever had and all places where you have evacuated your trade carts to.

A good way to fix it would be to find idle trade carts with the idle worker hotkey too.

If one keeps that idle worker hotkey pressed while holding the shift key at the same time, all idle trade carts would be selected.

[elexis]

As binaries/data/mods/public/gui/session/minimap_panel.xml indicates, the idle worker hotkey should already lead to idle trade carts:

<action on="Press">findIdleUnit(["Female", "Trade", "FishingBoat", "CitizenSoldier", "Healer"]);</action>

If you spawn an idle trade cart, it won't be found with that button though, despite their UnitAI state being INDIVIDUAL.IDLE and isIdle is true for that entity.

[elexis]

Typo fun.

[trompetin17]

In 16654:

Fixes #3248, patch by elexis