Attachments (4)
Change History (13)
by , 9 years ago
Attachment: | oosdump_r16988.7z added |
---|
comment:1 by , 9 years ago
mimo on #0ad-dev:
could it be that the first computation is done on the square map, before recognizing it is a circular map?
Full points. ;)
Yes, the problem appears to be that the cost grid for territories is sometimes calculated whilst the map is still a square, and is then not recalculated after the map is reshaped into a circle.
Oddly enough, its the host that ends up with an incorrect cost grid - the rejoined client is calculating the grid correctly, albeit on the second go.
Coincidentally, I found that the map "Greek Acropolis Night (2)" also suffers from the same OOS problem.
The solution given in the soon-to-be-attached patch is to subscribe to and listen for a message that is transmitted when a map has changed shape, and to recompute the cost grid after receiving it.
comment:2 by , 9 years ago
Keywords: | review patch added |
---|
comment:4 by , 9 years ago
Keywords: | review removed |
---|
by , 9 years ago
Attachment: | commands_cheatphase.txt added |
---|
Uses cheat to change phase on turn 0, serializationtest error on turn 1. r17131
comment:5 by , 9 years ago
Priority: | Release Blocker → Should Have |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
Couldn't reproduce the error by phasing without cheats (yet?).
< "peakPercentMapControlled": 5, < "teamPeakPercentMapControlled": 5 --- > "peakPercentMapControlled": 9, > "teamPeakPercentMapControlled": 9
by , 9 years ago
Attachment: | t3399_serialize_mapcontrol_trigger_v1.patch added |
---|
Fixes the OOS in case we would not commit #3525. If we commit that, then this patch is not necessary anymore (at least for this particular case where we age using a cheat). We might want to serialize it anyway, as there might be other unidentified cases.
comment:6 by , 9 years ago
Keywords: | review added |
---|---|
Priority: | Should Have → Must Have |
Summary: | OOS on rejoin - percentage of map controlled → [PATCH] OOS on rejoin - percentage of map controlled |
comment:7 by , 9 years ago
Owner: | changed from | to
---|---|
Status: | reopened → new |
comment:9 by , 9 years ago
Keywords: | patch review removed |
---|
I decided to adopt #3525's fix over this one. Thanks for the patch anyway.
Sample for r16988. Set of commands not minimized yet. Can't do serializationtest because of #3400.