Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3401 closed defect (fixed)

[PATCH] Structure Tree - Aristeia's egyptian phase-pair technologies cause errors

Reported by: s0600204 Owned by: s0600204
Priority: Should Have Milestone: Alpha 19
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

To reproduce:

  • Run 0ad with the aristeia mod enabled
  • Go to the structure tree (either off the main menu, or by clicking on the emblem top-centre in-game)
  • Choose the 'Egyptian' civ from the dropdown
  • Notice the error message

The error is caused because the mod's Egyptian civ presents a choice of two possible city-phase techs to the player, and the structree is unable to cope with this.

The attached patch fixes:

  • The structree's inability to deal with a phase-pair
  • The fact that units dependant on said phase-pair were not appearing where they should or, in fact, at all

Attachments (1)

structreePhasePairFix.patch (5.5 KB ) - added by s0600204 9 years ago.

Download all attachments as: .zip

Change History (4)

by s0600204, 9 years ago

Attachment: structreePhasePairFix.patch added

comment:1 by Stan, 9 years ago

Milestone: BacklogAlpha 19

comment:2 by Itms, 9 years ago

Resolution: fixed
Status: newclosed

In 17073:

Make the structure tree support paired technologies. Patch by s0600204, fixes #3401.

comment:3 by Itms, 9 years ago

Keywords: review removed

I just realized my commit message is not really accurate. Anyway, I enhanced the style a bit (trailing space, more curly braces, and early returns).

Thanks for this patch :)

Note: See TracTickets for help on using tickets.