Opened 9 years ago

Closed 9 years ago

#3533 closed defect (fixed)

[PATCH] Remove GetBestAttack function in Attack.js

Reported by: Stan Owned by: Stan
Priority: Should Have Milestone: Alpha 19
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by Stan)

r17109 commited a strange version of #3284 some parts were changed. As a result we now have an unused function in Attack.js

GetBestAttack();

That function should be removed. I checked all the js files in the public folder and none of them use it anymore.

Attachments (1)

3533.diff​ (740 bytes ) - added by Stan 9 years ago.
A proposal

Download all attachments as: .zip

Change History (3)

by Stan, 9 years ago

Attachment: 3533.diff​ added

A proposal

comment:1 by Stan, 9 years ago

Description: modified (diff)
Keywords: patch review added
Milestone: Backlog → Alpha 19
Owner: set to Stan
Status: new → assigned
Summary: Remove GetBestAttack function in Attack.js → [PATCH] Remove GetBestAttack function in Attack.js

comment:2 by mimo, 9 years ago

Keywords: review removed
Resolution: → fixed
Status: assigned → closed

fixed in r17139

Note: See TracTickets for help on using tickets.