commands changes depending on selected units

[ffm]

commands changes depending on selected units

The commands changes depending on the units inside the group and is very inconsistent and counterintuitive.

Examples (how it is now): rightclick with man on enemy unit= attack rightclick with man + women on enemy unit (except enemy women)= move rightclick with man + women on enemy women= attack rightclick with man + warelephant/siege on enemy structure= Elephant/siege attacks, man captures (icon promises capture)

attack a structure with a siege (health <100%), enemy captures siege. Now there is no way to recapture the siege (while its yours) before it's 100% repaired. So you repair the siege and enemy gets a repaired siege.

Some suggestions on how it should be:

The default rightclick action and modifier-key-action should be settable in local.cfg

The modifier keys should be consistent. One key to repair, one for garrison, one for attack etc.

Modifier with two actions make only sense if the actions have nothing in common. For example garrison and attack. If i press attack and press on my structure an attack would make no sense, so we could use one key. All is independent configurable in the local.cfg (like attack=ctrl; garrison=ctrl;

The default action for rightclick on enemy man should always be attack, regardless if there is a women or trader in the group.

With man and siege rightclick on enemy building (man captures and siege destroys) should get a new icon.

related #3564

[wraitii]

I think the worst case is the "warriors + women on enemy unit = move", which is absolutely infuriating when you're trying to defend against a raid and select citizen soldiers and women.

I'm setting this as a must have because I feel like it's a super annoying UI issue.

[Itms]

Also #2159

[ffm]

additional suggestions: -ctrl + selection rectangle = select all but soldiers (courser could change as indicator) -alt + selection rectangle = select all soldiers (no women, trader, work elephant) (it is already, only change would be the courser icon)

-rightclick with man + women on enemy unit (except enemy women)= move(for women) and attack(for men) the player receives a little punishment for giving unspecific orders.

[Eric Ongerth]

I believe I have also seen situations where I selected a group with warriors, no women, but included some healers, even checked carefully to exclude or remove any women. But even the inclusion of healers resulted in changing the available attack / capture / etc options.

[elexis]

Backlogging due to lack of progress.

[elexis]

In 18773:

Correctly handle commands and production for multiple units and mixed selections. Patch by Imarok, reviewed by Itms, fixes #3823. Fixes #3492, #3288, #3668.

[elexis]

• Notice the new repair hotkey (J), wiki:HotKeys, also displayed in the tooltip of the button.
• Created #4258 for the new cursor.