Opened 8 years ago

Last modified 3 years ago

#3724 new enhancement

[PATCH] Add hotkey to hide territory borders (for promotional screenshots)

Reported by: leper Owned by:
Priority: Nice to Have Milestone: Backlog
Component: UI – In-game Keywords: patch, simple
Cc: Patch:

Description

For some promotional screenshots it would be nice to hide territory borders (and maybe also selection overlays) by pressing a hotkey.

r17594 added overrides to cmpTerritoryManager (and to cmpOverlayRenderer) to stop displaying the territories (and overlays). These might need to be exported to JS (see the ICmp*.cpp files) so that the GUI can use them (via cmpGuiInterface).

Attachments (2)

t3724_v1.2.patch​ (5.8 KB ) - added by Sergey Kushnirenko 8 years ago.
t3724_v1.patch​ (5.8 KB ) - added by Sergey Kushnirenko 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 by Sergey Kushnirenko, 8 years ago

Keywords: review patch added
Milestone: Backlog → Alpha 20
Summary: Add hotkey to hide territory borders (for promotional screenshots) → [PATCH] Add hotkey to hide territory borders (for promotional screenshots)

by Sergey Kushnirenko, 8 years ago

Attachment: t3724_v1.2.patch​ added

by Sergey Kushnirenko, 8 years ago

Attachment: t3724_v1.patch​ added

comment:2 by Stan, 8 years ago

That patch looks okay, but I'm not sure about the return false line 873 in GuiInterface.js Also, which one is the correct one ? Should we follow the version, or the date of upload ?

Last edited 8 years ago by Stan (previous) (diff)

comment:3 by Sergey Kushnirenko, 8 years ago

Elexis said that avoid using guiinterface for return param, so i think about move those functions to other place, but i dont know engine well.Maybe you may suggest where it can be placed?

comment:4 by Itms, 8 years ago

Milestone: Alpha 20 → Alpha 21

comment:5 by sanderd17, 8 years ago

Why did you add the SetOverrideVisibility function? I don't see it being used anywhere else. And is there a difference between both patches?

The rest seems fairly good.

comment:6 by sanderd17, 8 years ago

Keywords: review removed

comment:7 by elexis, 8 years ago

Backlogging due to lack of progress.

comment:8 by elexis, 8 years ago

Milestone: Alpha 21 → Backlog

comment:9 by Imarok, 5 years ago

Component: UI & Simulation → In-game UI

Move tickets to In-game UI as UI & Simulation got some sub components.

comment:10 by Silier, 3 years ago

Keywords: simple removed
severity: → simple

comment:11 by Silier, 3 years ago

Keywords: simple added
Note: See TracTickets for help on using tickets.