[PATCH] Show rallypoints to observers

[elexis]

It would be nice if rallypoints are shown to observers / in replays (see #3168).

Also there is a bug if other clients update the rallypoint for the current player (via change-perspective or control-all-units). The rallypoint-renderer is not updated with the new coordinates and will continue to show the old rallypoint.

The attached patch sends a GUI notification if a rallypoint command was executed. It updates the rallypoint-renderer.

[elexis]

Unfortunately I noticed a bug with this implementation. In case one quickly clicks many rallypoints, sometimes the flags might remain after clearing the waypoint. I'm assuming this is because the DisplayRallyPoint is executed locally and then again when the GUINotification arrives (while it probably should be executed only once in case the local client sent the command).

[elexis]

The bug is already in the code and also occurs if only the local player sets rallypoints.

Reproduce:

1. Shift-click some rallypoints.
2. Rightclick on the building (to delete the rallypoints) and quickly shift-click a new rallypoint.

Result: The rallypoints (and lines connecting them) disappear. Then they appear again but with the latest rallypoint being connected to the previous (deleted) rallypoints. Then the lines between the rallypoints disappear while the flags remain.

This must be due to the fact that the rallypoint-renderer component is updated immediately and with the network-synchronization as well.

[elexis]

Backlogging due to lack of progress.

[Imarok]

Move tickets to In-game UI as UI & Simulation got some sub components.