[PATCH] Build error at Fedora 23

[bb]

The build of svn, A19 and A20 fails at Fedora 23 when linking tests. It gives the following error:

 /usr/bin/ld: obj/test_Release/test_root.o: relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
obj/test_Release/test_root.o: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
test.make:163: recipe for target '../../../binaries/system/test' failed
make[1]: *** [../../../binaries/system/test] Error 1
Makefile:92: recipe for target 'test' failed
make: *** [test] Error 2

Attached patch resolves the error and let the game run normally (it has been applied for me last few month).

[Itms]

The patch seems really hacky and could cause problems (you add this new flag for all Linux and BSD platforms...)

Could you try to understand why the problem happens specifically on your system? So we can fix this less "brutally" ;)

[fabio]

Debian also provide a hardening patch that may be useful to look at, see #1416.

[Itms]

I think a proper fix would be to add a --hardened flag to our premake scripts, for people who need/want that.

[Andy Alt]

/usr/bin/ld: obj/test_Release/test_root.o: relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC obj/test_Release/test_root.o: error adding Symbols: Bad value

How could more output be added to determine the cause?

[Itms]

This patch, more minimal, fixes the issue for me on Fedora 24.

On second thought, adding this build flag doesn't seem too much of a big change (we already use it for Atlas, and it is not a breaking change but rather a small tweak in the compilation process).

However it would need intensive testing on all flavors of Linux and BSD. Could people test that on as many platforms as possible and report on the ticket? Thanks.

[Itms]

In 18729:

Fix building on Fedora, by adding the Position Independant Code flag when building with gcc. This flag is not supposed to break anything and did not cause troubles when testing it on some other platforms than Fedora.

Based on patch by bb, fixes #3869

[Itms]

Thanks for working on the issue :)