#3901 closed defect (fixed)
[PATCH] Changing music gain doesn't have any effect
Reported by: | Erik Johansson | Owned by: | Damien PIQUET |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description
Reported by a user on Facebook, but in a quick testing on Alpha 20 I could reporoduce it. Changing the general volume gain works, but not the music gain. As far as I can tell the other gain settings work as well, but it's a bit involved to test e.g. the ambience so I'm not 100% sure about that.
Attachments (2)
Change History (11)
comment:1 by , 8 years ago
comment:2 by , 8 years ago
Milestone: | Alpha 21 → Backlog |
---|
by , 8 years ago
Attachment: | 3901.patch added |
---|
comment:3 by , 8 years ago
This problem only happens in the main menu.
=> in game, music is paused when in options menu. Music is resumed with the updated gain => in the main menu, music is playing when in options menu so it's not updated immediately.
comment:4 by , 8 years ago
Keywords: | review patch added |
---|---|
Milestone: | Backlog → Alpha 21 |
Summary: | Changing music gain doesn't have any effect → [PATCH] Changing music gain doesn't have any effect |
comment:5 by , 8 years ago
Owner: | set to |
---|
comment:6 by , 8 years ago
Thanks for coming up with a patch!
Did you try if m_CurrentTune->SetGain
might be sufficient already? In my opinion it would be better to set the gain immediately rather than having to wait for one second to check the actual sound output (not a big problem though).
comment:7 by , 8 years ago
That works too, and will probably be better when volume sliders will be implemented (saw a couple todos on the js side). Attached updated patch.
comment:9 by , 8 years ago
Keywords: | review removed |
---|
Thanks for the patch, and thanks to feneur for filing a report!
Backlogging due to lack of progress.