[PATCH] Remove player argument from GUIInterface calls
The new observermode #3168 has added a viewedPlayer
argument to a good number of GUIInteface
calls. It were cleaner to remove the player
and let the caller function pass it explicitly, so those functions would have only one argument (which is an object in case multiple arguments need to be passed).
Change History
(4)
Keywords: |
review patch added; simple removed
|
Milestone: |
Backlog → Alpha 21
|
Summary: |
Remove player argument from GUIInterface calls → [PATCH] Remove player argument from GUIInterface calls
|
Owner: |
set to elexis
|
Resolution: |
→ fixed
|
Status: |
new → closed
|
Keywords: |
review removed
|
Priority: |
Nice to Have → Should Have
|
Type: |
enhancement → defect
|
Default to the viewed player in the GUIInterface to avoid passing the viewed player separately in some places, refs #3168.
Makes the clearing of the cache in
selectViewPlayer
ofsession.js
actually relevant. Thereby fixes a fog-of-war selection relict when changing the perspective as described in #3850. This was trivial following r18201. Also removes some unused player arguments.