Opened 8 years ago
Closed 8 years ago
#4021 closed defect (fixed)
[PATCH] Merge duplicate library templates
Reported by: | Palaxin | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description (last modified by )
Attachments (3)
Change History (11)
by , 8 years ago
Attachment: | 4021_v1.patch added |
---|
by , 8 years ago
Attachment: | 4021_v2.patch added |
---|
comment:1 by , 8 years ago
Description: | modified (diff) |
---|
comment:3 by , 8 years ago
Keywords: | simple added; review removed |
---|
Thanks for the patches!
#4016, #4021, #4022 should have been one ticket.Not closing this one until all duplicate templates are nuked. spart_syssiton
and athen_gymnasion
are not similar enough to be merged, but the seleucid and ptolemian military colony are.
You (or the next person to upload patch) should merge the military colonies and ensure there are no remaining duplicates.
comment:4 by , 8 years ago
(i don't know if the two military colonies should be merged, as it was first planned to have a mercenary camp for ptols and a military colony for sele or something like that iirc, perhaps we should have ask that to leper for example). I didn't merge the VisualActor part as it should (as in i hope) be (soon) different.
comment:5 by , 8 years ago
- Ptol and sel can only build one civic center, so if that assumption will be kept, these civs will likely also be able to build the military colony to expand.
- Were these all duplicate templates now?
comment:6 by , 8 years ago
At least I can't think of other buildings where it would be worth to make a parent template.
"Duplicated" tickets with the aim to remove duplication is a bad idea indeed :D
comment:8 by , 8 years ago
Keywords: | simple removed |
---|---|
Priority: | Should Have → Nice to Have |
Resolution: | → fixed |
Status: | new → closed |
Thanks for all patches, I hope those were all dupes. Reopen the ticket if you find anything more before the next release.
now starting with "binaries/data/..." - I never get this right first :p