wcscasecmp does not exist on OS X

[Philip Taylor]

We use wcscasecmp but it does not exist on OS X, causing errors. We should either define that function ourselves on OS X (possibly a bad idea since it might conflict with a system version in the future, and we would not bother with the locale support that the standard expects), or define a similar function with a new name (probably in lib/wchar.cpp, just doing ASCII-case-insensitive comparisons) and use that on all platforms.

[Andrew]

wcscasecmp

[Andrew]

should be noted this will only work in 10.4 and higher

[Philip Taylor]

Thanks! I see a couple of problems:

wcscpy copies the string's null terminator, but wcslen returns the length without the terminator, so the allocated buffers are too small (it should be sizeof(wchar_t) * (wcslen(s1)+1) etc).

It would be better not to do any dynamic memory allocation at all (since that can be expensive) - rather than creating strings for wcscmp, I think it should just loop over both input strings at the same time, and return positive/negative values if the towlower()ed characters differ.

[Andrew]

okay I have made some changes :P

[philip]

(In [7217]) # Fix OS X build error Fixes #414 (wcscasecmp does not exist on OS X), based on patch from wacko

[(none)]

Milestone Unclassified deleted