Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4285 closed defect (fixed)

[PATCH] Take account of control group when checking if we can upgrade an entity.

Reported by: fatherbushido Owned by: fatherbushido
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

Attached patch:

  • takes into account the control group when checking placement before an upgrade
  • uses a new function to avoid duplication
  • fixes (?) a call to an unknown function

I join also a patch using that for wall towers wich could fix nicely #3811 (screenshot) following an idea of FeXor and Mythos_Ruler (in 3 years ago discussions on the forum).

Attachments (2)

upgrade_controlgroup.diff (2.6 KB ) - added by fatherbushido 8 years ago.
upgrade_wallturret.diff (5.2 KB ) - added by fatherbushido 8 years ago.
more accurate strings are not included

Download all attachments as: .zip

Change History (5)

by fatherbushido, 8 years ago

Attachment: upgrade_controlgroup.diff added

by fatherbushido, 8 years ago

Attachment: upgrade_wallturret.diff added

more accurate strings are not included

comment:1 by fatherbushido, 8 years ago

In the wall turret patch there is only the macedonian walls. Stuff should be done carefully (celtic wall towers, look at roman siege walls too) but I wait if the approach is good.

Last edited 8 years ago by fatherbushido (previous) (diff)

comment:2 by fatherbushido, 8 years ago

Owner: set to fatherbushido
Resolution: fixed
Status: newclosed

In 18878:

Take account of control group when checking if we can upgrade an entity. Fix a call to an unknown function. Style reviewed by elexis, logic overviewed by wraitii. Fix #4285.

comment:3 by fatherbushido, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.